Code Monkey home page Code Monkey logo

common-shakeify's Introduction

browserify

require('modules') in the browser

Use a node-style require() to organize your browser code and load modules installed by npm.

browserify will recursively analyze all the require() calls in your app in order to build a bundle you can serve up to the browser in a single <script> tag.

build status

browserify!

getting started

If you're new to browserify, check out the browserify handbook and the resources on browserify.org.

example

Whip up a file, main.js with some require()s in it. You can use relative paths like './foo.js' and '../lib/bar.js' or module paths like 'gamma' that will search node_modules/ using node's module lookup algorithm.

var foo = require('./foo.js');
var bar = require('../lib/bar.js');
var gamma = require('gamma');

var elem = document.getElementById('result');
var x = foo(100) + bar('baz');
elem.textContent = gamma(x);

Export functionality by assigning onto module.exports or exports:

module.exports = function (n) { return n * 111 }

Now just use the browserify command to build a bundle starting at main.js:

$ browserify main.js > bundle.js

All of the modules that main.js needs are included in the bundle.js from a recursive walk of the require() graph using required.

To use this bundle, just toss a <script src="bundle.js"></script> into your html!

install

With npm do:

npm install browserify

usage

Usage: browserify [entry files] {OPTIONS}

Standard Options:

    --outfile, -o  Write the browserify bundle to this file.
                   If unspecified, browserify prints to stdout.

    --require, -r  A module name or file to bundle.require()
                   Optionally use a colon separator to set the target.

      --entry, -e  An entry point of your app

     --ignore, -i  Replace a file with an empty stub. Files can be globs.

    --exclude, -u  Omit a file from the output bundle. Files can be globs.

   --external, -x  Reference a file from another bundle. Files can be globs.

  --transform, -t  Use a transform module on top-level files.

    --command, -c  Use a transform command on top-level files.

  --standalone -s  Generate a UMD bundle for the supplied export name.
                   This bundle works with other module systems and sets the name
                   given as a window global if no module system is found.

       --debug -d  Enable source maps that allow you to debug your files
                   separately.

       --help, -h  Show this message

For advanced options, type `browserify --help advanced`.

Specify a parameter.
Advanced Options:

  --insert-globals, --ig, --fast    [default: false]

    Skip detection and always insert definitions for process, global,
    __filename, and __dirname.

    benefit: faster builds
    cost: extra bytes

  --insert-global-vars, --igv

    Comma-separated list of global variables to detect and define.
    Default: __filename,__dirname,process,Buffer,global

  --detect-globals, --dg            [default: true]

    Detect the presence of process, global, __filename, and __dirname and define
    these values when present.

    benefit: npm modules more likely to work
    cost: slower builds

  --ignore-missing, --im            [default: false]

    Ignore `require()` statements that don't resolve to anything.

  --noparse=FILE

    Don't parse FILE at all. This will make bundling much, much faster for giant
    libs like jquery or threejs.

  --no-builtins

    Turn off builtins. This is handy when you want to run a bundle in node which
    provides the core builtins.

  --no-commondir

    Turn off setting a commondir. This is useful if you want to preserve the
    original paths that a bundle was generated with.

  --no-bundle-external

    Turn off bundling of all external modules. This is useful if you only want
    to bundle your local files.

  --bare

    Alias for both --no-builtins, --no-commondir, and sets --insert-global-vars
    to just "__filename,__dirname". This is handy if you want to run bundles in
    node.

  --no-browser-field, --no-bf

    Turn off package.json browser field resolution. This is also handy if you
    need to run a bundle in node.

  --transform-key

    Instead of the default package.json#browserify#transform field to list
    all transforms to apply when running browserify, a custom field, like, e.g.
    package.json#browserify#production or package.json#browserify#staging
    can be used, by for example running:
    * `browserify index.js --transform-key=production > bundle.js`
    * `browserify index.js --transform-key=staging > bundle.js`

  --node

    Alias for --bare and --no-browser-field.

  --full-paths

    Turn off converting module ids into numerical indexes. This is useful for
    preserving the original paths that a bundle was generated with.

  --deps

    Instead of standard bundle output, print the dependency array generated by
    module-deps.

  --no-dedupe

    Turn off deduping.

  --list

    Print each file in the dependency graph. Useful for makefiles.

  --extension=EXTENSION

    Consider files with specified EXTENSION as modules, this option can used
    multiple times.

  --global-transform=MODULE, -g MODULE

    Use a transform module on all files after any ordinary transforms have run.

  --ignore-transform=MODULE, -it MODULE

    Do not run certain transformations, even if specified elsewhere.

  --plugin=MODULE, -p MODULE

    Register MODULE as a plugin.

Passing arguments to transforms and plugins:

  For -t, -g, and -p, you may use subarg syntax to pass options to the
  transforms or plugin function as the second parameter. For example:

    -t [ foo -x 3 --beep ]

  will call the `foo` transform for each applicable file by calling:

    foo(file, { x: 3, beep: true })

compatibility

Many npm modules that don't do IO will just work after being browserified. Others take more work.

Many node built-in modules have been wrapped to work in the browser, but only when you explicitly require() or use their functionality.

When you require() any of these modules, you will get a browser-specific shim:

Additionally, if you use any of these variables, they will be defined in the bundled output in a browser-appropriate way:

  • process
  • Buffer
  • global - top-level scope object (window)
  • __filename - file path of the currently executing file
  • __dirname - directory path of the currently executing file

more examples

external requires

You can just as easily create a bundle that will export a require() function so you can require() modules from another script tag. Here we'll create a bundle.js with the through and duplexer modules.

$ browserify -r through -r duplexer -r ./my-file.js:my-module > bundle.js

Then in your page you can do:

<script src="bundle.js"></script>
<script>
  var through = require('through');
  var duplexer = require('duplexer');
  var myModule = require('my-module');
  /* ... */
</script>

external source maps

If you prefer the source maps be saved to a separate .js.map source map file, you may use exorcist in order to achieve that. It's as simple as:

$ browserify main.js --debug | exorcist bundle.js.map > bundle.js

Learn about additional options here.

multiple bundles

If browserify finds a required function already defined in the page scope, it will fall back to that function if it didn't find any matches in its own set of bundled modules.

In this way, you can use browserify to split up bundles among multiple pages to get the benefit of caching for shared, infrequently-changing modules, while still being able to use require(). Just use a combination of --external and --require to factor out common dependencies.

For example, if a website with 2 pages, beep.js:

var robot = require('./robot.js');
console.log(robot('beep'));

and boop.js:

var robot = require('./robot.js');
console.log(robot('boop'));

both depend on robot.js:

module.exports = function (s) { return s.toUpperCase() + '!' };
$ browserify -r ./robot.js > static/common.js
$ browserify -x ./robot.js beep.js > static/beep.js
$ browserify -x ./robot.js boop.js > static/boop.js

Then on the beep page you can have:

<script src="common.js"></script>
<script src="beep.js"></script>

while the boop page can have:

<script src="common.js"></script>
<script src="boop.js"></script>

This approach using -r and -x works fine for a small number of split assets, but there are plugins for automatically factoring out components which are described in the partitioning section of the browserify handbook.

api example

You can use the API directly too:

var browserify = require('browserify');
var b = browserify();
b.add('./browser/main.js');
b.bundle().pipe(process.stdout);

methods

var browserify = require('browserify')

browserify([files] [, opts])

Returns a new browserify instance.

files
String, file object, or array of those types (they may be mixed) specifying entry file(s).
opts
Object.

files and opts are both optional, but must be in the order shown if both are passed.

Entry files may be passed in files and / or opts.entries.

External requires may be specified in opts.require, accepting the same formats that the files argument does.

If an entry file is a stream, its contents will be used. You should pass opts.basedir when using streaming files so that relative requires can be resolved.

opts.entries has the same definition as files.

opts.noParse is an array which will skip all require() and global parsing for each file in the array. Use this for giant libs like jquery or threejs that don't have any requires or node-style globals but take forever to parse.

opts.transform is an array of transform functions or modules names which will transform the source code before the parsing.

opts.ignoreTransform is an array of transformations that will not be run, even if specified elsewhere.

opts.plugin is an array of plugin functions or module names to use. See the plugins section below for details.

opts.extensions is an array of optional extra extensions for the module lookup machinery to use when the extension has not been specified. By default browserify considers only .js and .json files in such cases.

opts.basedir is the directory that browserify starts bundling from for filenames that start with ..

opts.paths is an array of directories that browserify searches when looking for modules which are not referenced using relative path. Can be absolute or relative to basedir. Equivalent of setting NODE_PATH environmental variable when calling browserify command.

opts.commondir sets the algorithm used to parse out the common paths. Use false to turn this off, otherwise it uses the commondir module.

opts.fullPaths disables converting module ids into numerical indexes. This is useful for preserving the original paths that a bundle was generated with.

opts.builtins sets the list of built-ins to use, which by default is set in lib/builtins.js in this distribution.

opts.bundleExternal boolean option to set if external modules should be bundled. Defaults to true.

When opts.browserField is false, the package.json browser field will be ignored. When opts.browserField is set to a string, then a custom field name can be used instead of the default "browser" field.

When opts.insertGlobals is true, always insert process, global, __filename, and __dirname without analyzing the AST for faster builds but larger output bundles. Default false.

When opts.detectGlobals is true, scan all files for process, global, __filename, and __dirname, defining as necessary. With this option npm modules are more likely to work but bundling takes longer. Default true.

When opts.ignoreMissing is true, ignore require() statements that don't resolve to anything.

When opts.debug is true, add a source map inline to the end of the bundle. This makes debugging easier because you can see all the original files if you are in a modern enough browser.

When opts.standalone is a non-empty string, a standalone module is created with that name and a umd wrapper. You can use namespaces in the standalone global export using a . in the string name as a separator, for example 'A.B.C'. The global export will be sanitized and camel cased.

Note that in standalone mode the require() calls from the original source will still be around, which may trip up AMD loaders scanning for require() calls. You can remove these calls with derequire:

$ npm install derequire
$ browserify main.js --standalone Foo | derequire > bundle.js

opts.insertGlobalVars will be passed to insert-module-globals as the opts.vars parameter.

opts.externalRequireName defaults to 'require' in expose mode but you can use another name.

opts.bare creates a bundle that does not include Node builtins, and does not replace global Node variables except for __dirname and __filename.

opts.node creates a bundle that runs in Node and does not use the browser versions of dependencies. Same as passing { bare: true, browserField: false }.

Note that if files do not contain javascript source code then you also need to specify a corresponding transform for them.

All other options are forwarded along to module-deps and browser-pack directly.

b.add(file, opts)

Add an entry file from file that will be executed when the bundle loads.

If file is an array, each item in file will be added as an entry file.

b.require(file, opts)

Make file available from outside the bundle with require(file).

The file param is anything that can be resolved by require.resolve(), including files from node_modules. Like with require.resolve(), you must prefix file with ./ to require a local file (not in node_modules).

file can also be a stream, but you should also use opts.basedir so that relative requires will be resolvable.

If file is an array, each item in file will be required. In file array form, you can use a string or object for each item. Object items should have a file property and the rest of the parameters will be used for the opts.

Use the expose property of opts to specify a custom dependency name. require('./vendor/angular/angular.js', {expose: 'angular'}) enables require('angular')

b.bundle(cb)

Bundle the files and their dependencies into a single javascript file.

Return a readable stream with the javascript file contents or optionally specify a cb(err, buf) to get the buffered results.

b.external(file)

Prevent file from being loaded into the current bundle, instead referencing from another bundle.

If file is an array, each item in file will be externalized.

If file is another bundle, that bundle's contents will be read and excluded from the current bundle as the bundle in file gets bundled.

b.ignore(file)

Prevent the module name or file at file from showing up in the output bundle.

If file is an array, each item in file will be ignored.

Instead you will get a file with module.exports = {}.

b.exclude(file)

Prevent the module name or file at file from showing up in the output bundle.

If file is an array, each item in file will be excluded.

If your code tries to require() that file it will throw unless you've provided another mechanism for loading it.

b.transform(tr, opts={})

Transform source code before parsing it for require() calls with the transform function or module name tr.

If tr is a function, it will be called with tr(file) and it should return a through-stream that takes the raw file contents and produces the transformed source.

If tr is a string, it should be a module name or file path of a transform module with a signature of:

var through = require('through');
module.exports = function (file) { return through() };

You don't need to necessarily use the through module. Browserify is compatible with the newer, more verbose Transform streams built into Node v0.10.

Here's how you might compile coffee script on the fly using .transform():

var coffee = require('coffee-script');
var through = require('through');

b.transform(function (file) {
    var data = '';
    return through(write, end);

    function write (buf) { data += buf }
    function end () {
        this.queue(coffee.compile(data));
        this.queue(null);
    }
});

Note that on the command-line with the -c flag you can just do:

$ browserify -c 'coffee -sc' main.coffee > bundle.js

Or better still, use the coffeeify module:

$ npm install coffeeify
$ browserify -t coffeeify main.coffee > bundle.js

If opts.global is true, the transform will operate on ALL files, despite whether they exist up a level in a node_modules/ directory. Use global transforms cautiously and sparingly, since most of the time an ordinary transform will suffice. You can also not configure global transforms in a package.json like you can with ordinary transforms.

Global transforms always run after any ordinary transforms have run.

Transforms may obtain options from the command-line with subarg syntax:

$ browserify -t [ foo --bar=555 ] main.js

or from the api:

b.transform('foo', { bar: 555 })

In both cases, these options are provided as the second argument to the transform function:

module.exports = function (file, opts) { /* opts.bar === 555 */ }

Options sent to the browserify constructor are also provided under opts._flags. These browserify options are sometimes required if your transform needs to do something different when browserify is run in debug mode, for example.

b.plugin(plugin, opts)

Register a plugin with opts. Plugins can be a string module name or a function the same as transforms.

plugin(b, opts) is called with the browserify instance b.

For more information, consult the plugins section below.

b.pipeline

There is an internal labeled-stream-splicer pipeline with these labels:

  • 'record' - save inputs to play back later on subsequent bundle() calls
  • 'deps' - module-deps
  • 'json' - adds module.exports= to the beginning of json files
  • 'unbom' - remove byte-order markers
  • 'unshebang' - remove #! labels on the first line
  • 'syntax' - check for syntax errors
  • 'sort' - sort the dependencies for deterministic bundles
  • 'dedupe' - remove duplicate source contents
  • 'label' - apply integer labels to files
  • 'emit-deps' - emit 'dep' event
  • 'debug' - apply source maps
  • 'pack' - browser-pack
  • 'wrap' - apply final wrapping, require= and a newline and semicolon

You can call b.pipeline.get() with a label name to get a handle on a stream pipeline that you can push(), unshift(), or splice() to insert your own transform streams.

b.reset(opts)

Reset the pipeline back to a normal state. This function is called automatically when bundle() is called multiple times.

This function triggers a 'reset' event.

package.json

browserify uses the package.json in its module resolution algorithm, just like node. If there is a "main" field, browserify will start resolving the package at that point. If there is no "main" field, browserify will look for an "index.js" file in the module root directory. Here are some more sophisticated things you can do in the package.json:

browser field

There is a special "browser" field you can set in your package.json on a per-module basis to override file resolution for browser-specific versions of files.

For example, if you want to have a browser-specific module entry point for your "main" field you can just set the "browser" field to a string:

"browser": "./browser.js"

or you can have overrides on a per-file basis:

"browser": {
  "fs": "level-fs",
  "./lib/ops.js": "./browser/opts.js"
}

Note that the browser field only applies to files in the local module, and like transforms, it doesn't apply into node_modules directories.

browserify.transform

You can specify source transforms in the package.json in the browserify.transform field. There is more information about how source transforms work in package.json on the module-deps readme.

For example, if your module requires brfs, you can add

"browserify": { "transform": [ "brfs" ] }

to your package.json. Now when somebody require()s your module, brfs will automatically be applied to the files in your module without explicit intervention by the person using your module. Make sure to add transforms to your package.json dependencies field.

events

b.on('file', function (file, id, parent) {})

b.pipeline.on('file', function (file, id, parent) {})

When a file is resolved for the bundle, the bundle emits a 'file' event with the full file path, the id string passed to require(), and the parent object used by browser-resolve.

You could use the file event to implement a file watcher to regenerate bundles when files change.

b.on('package', function (pkg) {})

b.pipeline.on('package', function (pkg) {})

When a package file is read, this event fires with the contents. The package directory is available at pkg.__dirname.

b.on('bundle', function (bundle) {})

When .bundle() is called, this event fires with the bundle output stream.

b.on('reset', function () {})

When the .reset() method is called or implicitly called by another call to .bundle(), this event fires.

b.on('transform', function (tr, file) {})

b.pipeline.on('transform', function (tr, file) {})

When a transform is applied to a file, the 'transform' event fires on the bundle stream with the transform stream tr and the file that the transform is being applied to.

plugins

For some more advanced use-cases, a transform is not sufficiently extensible. Plugins are modules that take the bundle instance as their first parameter and an option hash as their second.

Plugins can be used to do perform some fancy features that transforms can't do. For example, factor-bundle is a plugin that can factor out common dependencies from multiple entry-points into a common bundle. Use plugins with -p and pass options to plugins with subarg syntax:

browserify x.js y.js -p [ factor-bundle -o bundle/x.js -o bundle/y.js ] \
  > bundle/common.js

For a list of plugins, consult the browserify-plugin tag on npm.

list of source transforms

There is a wiki page that lists the known browserify transforms.

If you write a transform, make sure to add your transform to that wiki page and add a package.json keyword of browserify-transform so that people can browse for all the browserify transforms on npmjs.org.

third-party tools

There is a wiki page that lists the known browserify tools.

If you write a tool, make sure to add it to that wiki page and add a package.json keyword of browserify-tool so that people can browse for all the browserify tools on npmjs.org.

changelog

Releases are documented in changelog.markdown and on the browserify twitter feed.

license

MIT

browserify!

common-shakeify's People

Contributors

dependabot[bot] avatar dy avatar goto-bus-stop avatar josephg avatar pirxpilot avatar ralphtheninja avatar tornqvist avatar wooorm avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

common-shakeify's Issues

Verbose mode throws an error when --full-paths flag is not used

In verbose mode, the call to path.relative throws an error when --full-paths flag is not used. This is because the module name will be a number.

https://github.com/browserify/common-shakeify/blob/master/index.js#L30

Example:

$ browserify -g [ loose-envify purge --NODE_ENV production ] -p [ esmify ] -p [ common-shakeify -v ] -t babelify ./lib/index.js -o ./build/index.prod.js

internal/validators.js:112
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "to" argument must be of type string. Received type number
    at validateString (internal/validators.js:112:11)
    at Object.relative (path.js:1054:5)
    at /node_modules/common-shakeify/index.js:33:83
    at Array.forEach (<anonymous>)
    at Object.onModuleBailout (/node_modules/common-shakeify/index.js:28:17)
    at /node_modules/common-shakeify/index.js:152:14
    at Map.forEach (<anonymous>)
    at DestroyableTransform.onend [as _flush] (/node_modules/common-shakeify/index.js:140:22)
    at DestroyableTransform.prefinish (/node_modules/readable-stream/lib/_stream_transform.js:138:10)
    at DestroyableTransform.emit (events.js:223:5) {

emit event on verbose mode

It'd be cool for Bankai if we could catch the names of the pruned modules, and log them out as log-level debug. That way people can like debug what's going on inside bankai :D

Updating `@babel/core` to version 7.22.15+ shakes out needed exports

Running the following code results in a TypeError: (0 , _$b_2.fn3) is not a function error.

index.js

import { fn1 } from './a';

fn1();

a.js

import { fn3 } from './b';

export const fn2 = () => {
    fn3();
};

export const fn1 = () => {
    fn2();
};

b.js

export const fn3 = () => {};

It could be related to the way exports are transpiled, it changed from this:

exports.var = var;
var fn = function fn(arg) {

To this:

var fn = exports.fn = function fn(arg) {
@babel/core 7.22.11
(function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
"use strict";

Object.defineProperty(exports, "__esModule", {
  value: true
});
/* common-shake removed: exports.fn2 = */ exports.fn1 = void 0;
var _b = require("./b");
var fn2 = function fn2() {
  (0, _b.fn3)();
};
/* common-shake removed: exports.fn2 = */ void fn2;
var fn1 = function fn1() {
  fn2();
};
exports.fn1 = fn1;

},{"./b":2}],2:[function(require,module,exports){
"use strict";

Object.defineProperty(exports, "__esModule", {
  value: true
});
exports.fn3 = void 0;
var fn3 = function fn3() {};
exports.fn3 = fn3;

},{}],3:[function(require,module,exports){
"use strict";

var _a = require("./a");
(0, _a.fn1)();

},{"./a":1}]},{},[3])
@babel/core 7.22.15
(function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
"use strict";

Object.defineProperty(exports, "__esModule", {
  value: true
});
/* common-shake removed: exports.fn2 = */ exports.fn1 = void 0;
var _b = require("./b");
var fn2 = /* common-shake removed: exports.fn2 = */ function fn2() {
  (0, _b.fn3)();
};
var fn1 = exports.fn1 = function fn1() {
  fn2();
};

},{"./b":2}],2:[function(require,module,exports){
"use strict";

Object.defineProperty(exports, "__esModule", {
  value: true
});
/* common-shake removed: exports.fn3 = */ void void 0;
var fn3 = /* common-shake removed: exports.fn3 = */ function fn3() {};

},{}],3:[function(require,module,exports){
"use strict";

var _a = require("./a");
(0, _a.fn1)();

},{"./a":1}]},{},[3])

Some kind of error sometimes

So, if I have pull-ws in my choo app and use bankai as the dev server, bankai will crash when it first starts up; Then if I save a file, it recompiles and it works.

Chatted with @yoshuawuyts and we narrowed it down to common-shakeify by commenting out transforms in bankai (https://github.com/choojs/bankai/blob/master/lib/graph-script.js) until it worked.

Here's is the stack trace.

scripts:browserify.bundle Assigning to rvalue (3:45)
SyntaxError: Assigning to rvalue (3:45)
    at Parser.pp$4.raise (/Users/travis/source/commonshake/node_modules/acorn/dist/acorn.js:2610:13)
    at Parser.pp$2.toAssignable (/Users/travis/source/commonshake/node_modules/acorn/dist/acorn.js:1529:12)
    at Parser.pp$3.parseMaybeAssign (/Users/travis/source/commonshake/node_modules/acorn/dist/acorn.js:1839:47)
    at Parser.pp$3.parseExpression (/Users/travis/source/commonshake/node_modules/acorn/dist/acorn.js:1803:19)
    at Parser.pp$1.parseStatement (/Users/travis/source/commonshake/node_modules/acorn/dist/acorn.js:797:45)
    at Parser.pp$1.parseTopLevel (/Users/travis/source/commonshake/node_modules/acorn/dist/acorn.js:690:23)
    at Parser.parse (/Users/travis/source/commonshake/node_modules/acorn/dist/acorn.js:543:15)
    at parse (/Users/travis/source/commonshake/node_modules/acorn/dist/acorn.js:3669:37)
    at module.exports (/Users/travis/source/commonshake/node_modules/falafel/index.js:22:15)
    at /Users/travis/source/commonshake/node_modules/static-module/index.js:30:13

I made a repro repo
https://gist.github.com/laduke/7441c3564d74905f6d409924bccbf68f

Breaks split-require

I just noticed that #43 completely breaks split-require. Only module.exports = whatever work, but all named exports are dropped. I've created a test case in my fork but am struggling to figure out what's wrong.

I'm not fully familiar with the inner workings of split-require and even less so in combination with common-shakeify, @goto-bus-stop, can you see why this change would break split-require?

Originally posted by @tornqvist in #43 (comment)

[email protected] crashes with browserify --full-paths option

Issue did not exist in [email protected].

In [email protected], I started getting this error:

/Users/feross/code/bitmidi.com/node_modules/common-shakeify/index.js:92
    Object.keys(row.indexDeps).forEach((name) => {
           ^

TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at DestroyableTransform.onfile [as _transform] (/Users/feross/code/bitmidi.com/node_modules/common-shakeify/index.js:92:12)
    at DestroyableTransform.Transform._read (/Users/feross/code/bitmidi.com/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    at DestroyableTransform.Transform._write (/Users/feross/code/bitmidi.com/node_modules/readable-stream/lib/_stream_transform.js:172:83)
    at Labeled.Pipeline._write (/Users/feross/code/bitmidi.com/node_modules/stream-splicer/index.js:70:22)
    at doWrite (/Users/feross/code/bitmidi.com/node_modules/readable-stream/lib/_stream_writable.js:428:64)
    at writeOrBuffer (/Users/feross/code/bitmidi.com/node_modules/readable-stream/lib/_stream_writable.js:417:5)
    at Labeled.Writable.write (/Users/feross/code/bitmidi.com/node_modules/readable-stream/lib/_stream_writable.js:334:11)
    at Labeled.ondata (/Users/feross/code/bitmidi.com/node_modules/readable-stream/lib/_stream_readable.js:619:20)
    at Labeled.emit (events.js:198:13)
/Users/feross/code/bitmidi.com/node_modules/disc/bin/discify:59
    if (err) throw err
             ^

Looking at the changes made for 0.6.1 this definitely seems like it was introduced there. Haven't had a chance to look further into the cause.

The full command I'm using is browserify --no-detect-globals --extension mjs --plugin tinyify --full-paths . with latest browserify.

does not remove imports that belongs to dead code which is removed by common-shake

Thanks for the efforts. This plugin works great. I will try to explain the case i came across.

"index.es6" imports {Storage} from "abc" which intern import {Cookie} from "xyz".
"abc" is using {Cookie} from "xyz". But Index.es6 is not using {Storage} from "abc". Now common-shake is removing {Storage} from the code but {Cookie} remains in the output file. If I remove reference to {Cookie} from abc then common-shake is removing {Cookie} as well.

Here is the file structure

index.es6

import {Storage} from "./abc";
console.log("this is an example");

abc.es6

import {Cookie} from "./xyz";

export var Storage = function(){
}
Storage.prototype = {
  getCookie: function(){
    let cookie = new Cookie(); // if i remove this line then common-shake removes Cookie from the output
  }
}

xyz.es6

export var Cookie= function(){
}

Cookie.prototype = {
  readCookie: function(){
     console.log("reading cookie");
  }
}

encountering a spread operator results in fatal error

hello and thank you for all your great open source work! 👋

here's a simplified repro case for an error i'm running into in the wild.

// foo.js
const bar = require('./bar')
console.log(bar)

// bar.js
const baz = require('./baz')
module.exports = { ...baz }

// baz.js
module.exports = { foo: 3 }
# Node 14
% browserify foo.js -p [ common-shakeify -v ] -o bundle.js
/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/lib/shake/analyzer.js:367
        (prop.key.type !== 'Literal' && prop.key.type !== 'Identifier')) {
                  ^

TypeError: Cannot read property 'type' of undefined
    at Analyzer.siftModuleExports (/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/lib/shake/analyzer.js:367:19)
    at Analyzer.siftAssignment (/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/lib/shake/analyzer.js:329:10)
    at AssignmentExpression (/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/lib/shake/analyzer.js:256:40)
    at c (/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/lib/shake/walk.js:19:16)
    at Object.skipThrough (/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/node_modules/acorn-walk/dist/walk.js:186:39)
    at c (/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/lib/shake/walk.js:20:15)
    at Object.base.ExpressionStatement.base.ParenthesizedExpression (/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/node_modules/acorn-walk/dist/walk.js:204:37)
    at c (/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/lib/shake/walk.js:20:15)
    at Object.skipThrough (/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/node_modules/acorn-walk/dist/walk.js:186:39)
    at c (/Users/john/code/web/node_modules/@goto-bus-stop/common-shake/lib/shake/walk.js:20:15)

right now i'm using babelify and working around this issue by transpiling for browsers that don't support spreading, but that's less than ideal.

i'd log an issue in common-shake, but i'm at a loss for what's going on under the hood.

Name is too long

Should've been "shakeify". Browserify is already just commonjs, so the "common" is unnecessary.

Bundle not tree-shaked even in the most simple use case

Here is a super simple package.js script:

var iconv = require('iconv-lite');

console.warn('We are not using iconv at all!');

As you can see, iconv is never used.

Using the CLI command of the documentation browserify -p [common-shakeify -v] package.js > bundle.js, the final bundle is not tree-shaked. There is only one common-shake comment in the generated bundle:

/* common-shake removed: exports.byteLength = */

I expect the whole iconv module to be removed since it is not used at all.

require('os') is broken

// a.js
var _ = require('./b')
// b.js
exports.a = exports.b = function () {}

browserify -p common-shakeify a.js produces

(function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
/* common-shake removed: exports.a = */ /* common-shake removed: exports.b = */ function () {}

},{}],2:[function(require,module,exports){
var a = require( './b' )

},{"./b":1}]},{},[2]);

Which is Uncaught SyntaxError: Unexpected token (.

Because we can't just do function () {} in javascript.

@goto-bus-stop

shakes out functions that I used

I'm not sure if this plugin in production ready yet, but it seems that it removed functions that I'm definitely using.

Using import to get the modules, but running babel as a browserify transform, so that should rewrite everything to require.

seems that most of the incorrectly removed functions are from the crypto-browserify package.

Browserify + common-shakeify + Chart.js = infinite stack trace

I created this issue here: chartjs/Chart.js#11479

Expected behavior

I'm using [email protected] + [email protected] + [email protected].

In JavaScript I have this:

const Chart = require('chart.js/auto');

console.log('Hello');

Bundling will give me a stack trace and a crash.

Current behavior

ile@ilepc:~/src/sc2/browserify-chartjs$ ./run.sh 
/home/ile/src/sc2/browserify-chartjs/node_modules/escope/lib/scope.js:417
            var ref = new _reference2.default(node, this, assign || _reference2.default.READ, writeExpr, maybeImplicitGlobal, !!partial, !!init);
                      ^

RangeError: Maximum call stack size exceeded
    at ClassScope.__referencing (/home/ile/src/sc2/browserify-chartjs/node_modules/escope/lib/scope.js:417:23)
    at Referencer.Identifier (/home/ile/src/sc2/browserify-chartjs/node_modules/escope/lib/referencer.js:425:33)
    at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:104:34)
    at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:88:26)
    at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:107:14)
    at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:83:38)
    at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:107:14)
    at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:88:26)
    at Visitor.visit (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:107:14)
    at Visitor.visitChildren (/home/ile/src/sc2/browserify-chartjs/node_modules/esrecurse/esrecurse.js:83:38)

Node.js v20.5.1

Reproducible sample

https://github.com/ile/browserify-chartjs

Optional extra steps/info to reproduce

No response

Possible solution

No response

Context

No response

chart.js version

v4.4.0

Browser name and version

No response

Link to your project

https://github.com/ile/browserify-chartjs

v1.1 has a bug compared to v0 and v1.0: require can't take a number

I get this error output in my tests:

  node:internal/validators:114
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "id" argument must be of type string. Received type number (298)
    at new NodeError (node:internal/errors:388:5)
    at validateString (node:internal/validators:114:11)
    at Module.require (node:internal/modules/cjs/loader:1005:3)
    at require (node:internal/modules/cjs/helpers:102:18)

I suspect this was introduced in #31.

Errors on browserify -r

Made a repro here
https://github.com/laduke/common-shake-repro

Hopefully i'm not just holding it wrong.
Looks like same message as from #10 ?

 browserify -r net-browserify-stub:net index.js -p common-shakeify
/common-shake-repro/node_modules/common-shakeify/index.js:239
  return row[kDuplicates] || [

TypeError: Cannot read property 'Symbol(duplicates)' of undefined
    at getDuplicates (/Users/travis/src/common-shake-repro/node_modules/common-shakeify/index.js:239:13)
    at analyzer.modules.forEach (/Users/travis/src/common-shake-repro/node_modules/common-shakeify/index.js:122:21)
    at Map.forEach (<anonymous>)
    at DestroyableTransform.onend [as _flush] (/Users/travis/src/common-shake-repro/node_modules/common-shakeify/index.js:119:22)
    at DestroyableTransform.prefinish (/Users/travis/src/common-shake-repro/node_modules/readable-stream/lib/_stream_transform.js:138:10)
    at DestroyableTransform.emit (events.js:197:13)
    at prefinish (/Users/travis/src/common-shake-repro/node_modules/readable-stream/lib/_stream_writable.js:619:14)
    at finishMaybe (/Users/travis/src/common-shake-repro/node_modules/readable-stream/lib/_stream_writable.js:627:5)
    at endWritable (/Users/travis/src/common-shake-repro/node_modules/readable-stream/lib/_stream_writable.js:638:3)
    at DestroyableTransform.Writable.end (/Users/travis/src/common-shake-repro/node_modules/readable-stream/lib/_stream_writable.js:594:41)

Using b.require with react and react-dom results in an error

> browserify -r react -r react-dom -p tinyify

/.../node_modules/tinyify/node_modules/common-shakeify/index.js:222
  return row[kDuplicates] || []
            ^

TypeError: Cannot read property 'Symbol(duplicates)' of undefined
    at getDuplicates (/.../node_modules/tinyify/node_modules/common-shakeify/index.js:222:13)
    at analyzer.modules.forEach (/.../node_modules/tinyify/node_modules/common-shakeify/index.js:121:21)
    at Map.forEach (<anonymous>)
    at DestroyableTransform.onend [as _flush] (/.../node_modules/tinyify/node_modules/common-shakeify/index.js:118:22)
    at DestroyableTransform.prefinish (/.../node_modules/readable-stream/lib/_stream_transform.js:138:10)
    at emitNone (events.js:106:13)
    at DestroyableTransform.emit (events.js:208:7)
    at prefinish (/.../node_modules/readable-stream/lib/_stream_writable.js:619:14)
    at finishMaybe (/.../node_modules/readable-stream/lib/_stream_writable.js:627:5)
    at endWritable (/.../node_modules/readable-stream/lib/_stream_writable.js:638:3)

It appears to only happen when I use them both; if I -r them separately then it works fine. I tried it with some simpler packages such as once and xtend together and that appeared to work just fine.

The package.json:

{
  "private": true,
  "scripts": {
    "test": "browserify -r react -r react-dom -p tinyify"
  },
  "dependencies": {
    "react": "16.6.3",
    "react-dom": "16.6.3"
  },
  "devDependencies": {
    "browserify": "16.2.3",
    "tinyify": "2.4.3"
  }
}

typedarray-pool is broken

Stumbled upon this in tinyify not working in dy/budo. typedarray-pool turned out to not shake properly.

The bug case:

// a.js
exports.x0 =
exports.x1 =
exports.x2 = function () {}
// b.js
require('./a').x0()

Produces

(function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
exports.x0 =
/* common-shake removed: exports.x1 = */ void 0, /* common-shake removed: exports.x2 = */ function () {}

},{}],2:[function(require,module,exports){
require('./a').x0()

},{"./a":1}]},{},[2]);

exports.x0 here === void 0

@goto-bus-stop

deduped modules

browserify dedupes modules with the same source, that looks like:

arguments[4][DEDUPED_MODULE_ID][0].apply(exports,arguments)

this is breaking common-shakeify detection of exports for those modules.

a reproduction:

require('i18next').use(require('i18next-xhr-backend'))

TypeError: Cannot read property 'Symbol(duplicates)' of undefined

getDuplicates fails with this when i use browserify --no-bundle-external.

  return row[kDuplicates] || []
             ^

TypeError: Cannot read property 'Symbol(duplicates)' of undefined
    at getDuplicates (/home/arch/Code/goto-bus-stop/common-shakeify/index.js:214:14)
    at analyzer.modules.forEach (/home/arch/Code/goto-bus-stop/common-shakeify/index.js:115:21)

remove unused modules if they have sideEffects: false

Following from #17, although we can't remove unused modules in the general case, if something does

var _ = require('lodash')
exports.a = function () { /* something not using lodash */ }
exports.b = function (x) { _.map(x, /* etc */) }

and you're not using exports.b, exports.b will be dropped, lodash becomes unused, and we can check the lodash package.json file to see that it is safe to remove the require() call.

So this is intended to address the case where all uses of a module have been shaken out, not for the case where it's not used in the first place—then it might be a polyfill or something.

Just upgraded to v1 - TypeError: Cannot read properties of undefined (reading 'dedupe')

Just upgraded the dependencies in an old project and tried re-running the browserify portion.

common-shakeify v1.1.1
Node 16.16.0
OSX Arm

b = browserify(options).plugin(commonShakeify, {});

b.transform('babelify', {
    presets: ['@babel/preset-env'],
    sourceMaps: true
  });

So just using the default options, but when running it I get:

TypeError: Cannot read properties of undefined (reading 'dedupe')
    at /node_modules/common-shakeify/index.js:150:15
    at Map.forEach (<anonymous>)
    at DestroyableTransform.onend [as _flush] (/node_modules/common-shakeify/index.js:143:22)
    at DestroyableTransform.prefinish (/node_modules/readable-stream/lib/_stream_transform.js:138:10)
    at DestroyableTransform.emit (node:events:527:28)
    at DestroyableTransform.emit (node:domain:537:15)
    at prefinish (/node_modules/readable-stream/lib/_stream_writable.js:619:14)
    at finishMaybe (/node_modules/readable-stream/lib/_stream_writable.js:627:5)
    at endWritable (/node_modules/readable-stream/lib/_stream_writable.js:638:3)
    at DestroyableTransform.Writable.end (/node_modules/readable-stream/lib/_stream_writable.js:594:41)
    at DestroyableTransform.onend (/node_modules/readable-stream/lib/_stream_readable.js:577:10)
    at Object.onceWrapper (node:events:641:28)
    at DestroyableTransform.emit (node:events:539:35)
    at DestroyableTransform.emit (node:domain:537:15)
    at endReadableNT (/node_modules/readable-stream/lib/_stream_readable.js:1010:12)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)

Any ideas what this might be? Not changed anything other than the version numbers of packages.

invalid output

fails on the ssr test in bankai

input:

var html = require('choo/html')
var choo = require('choo')

var app = choo()
app.route('/', function () {
  return html`<body>meow</body>`
})
if (module.parent) module.exports = app
else app.mount('body')

this is uglified first among other things, and causes invalid output from common-shakeify

Fails to shake Apollo Client

This plugin fails to shake Apollo Client leading to an immensely bloated bundle.

Apollo Client provides a CommonJS bundle, which allegedly is targeted for Node, but I can't see anything about that bundle which would throw off common-shakeify.

This simple example, which should include only the base ApolloClient class and its dependencies actually includes the entire Apollo Client bundle, resulting in a minified bundle size of ~490 kb.

// test.js
var { ApolloClient } = require('@apollo/client/core')
module.exports = new ApolloClient({})
$ npx browserify -p common-shakeify -g uglifyify test.js | wc -c
486954

This is the Apollo Client CommonJS bundle: https://unpkg.com/@apollo/[email protected]/core/core.cjs.js

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.