Code Monkey home page Code Monkey logo

firestore-coroutines's Introduction

Hi there 👋

firestore-coroutines's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

firestore-coroutines's Issues

Query.observe close listener

Will the firebase listener ever be closed/discarded if I stop using the Channel returned from the Query.observe extension function?

Documents that does not exist causes issues

Using DocumentReference.await(parser:): T causes problems on documents that does not exist. I expect the coroutine to resume with an exception, but it resumes and force unwraps the result in the parser, even when the result is a document that does not exist (e.g an empty reference). Please fix this issue, as is makes the await(parser:) function not able to be used for checking whether or not a document needs to be created at the specified location.

Suggested fix

´´´
suspend fun DocumentReference.await(parser: (documentSnapshot: DocumentSnapshot) -> T): T {
return suspendCoroutine { continuation ->
get().addOnCompleteListener {

            if (it.isSuccessful && it.result != null && it.result!!.exists()) {
                continuation.resume(parser.invoke(it.result!!))
            } else if (it.isSuccessful && it.result != null && !it.result!!.exists()) {
                continuation.resumeWithException(DocumentDoesNotExistsException())
            } else if (it.exception != null){
                continuation.resumeWithException(it.exception!!)
            } else {
                continuation.resumeWithException(EmptyStackException())
            }
        }
    }
}

´´´

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.