brony9tynine / prj-rev-bwfs-dasmoto Goto Github PK

0.0 0.0 0.0 1 KB

HTML 74.32% CSS 25.68%

prj-rev-bwfs-dasmoto's Issues

SUMMARY

Project name: Dasmoto's Arts & Crafts
Summary Grade: Needs Improvement

I did find what I feel are several errors with the website. Some are structural, the others involve accuracy. It's a good idea to leave comments in sections of the code like the ones below to help you or any other person seeing your code be able to get a general overall quick idea of what's correlating with what rather than skimming through the code and having to memorize class names and Id names. It's a good habit to keep up. A good example of this could be done like what I input below this.

<!-- EX: Brushes Section -->
<!-- EX: Frames Section -->
<!-- EX: Paint Section -->

Whenever you are working on a website with different sections, it's common practice to group each section with a

. This will help keep things organized and allow us to style it in more ways.

Here's an example:

<div id="brushes">
        <h2>Brushes</h2>
        <img ...>
        <h3>...</h3>
        <p>...<span>...</span></p>
      </div>

With this, we can now style any element by using the unique id as a starting point for the css selectors, for instance, if you wanted to change the background color of the <h2> element, we can do so like this:

#brushes h2 {
        background-color: ...;
      }

I suggest working on re-editing this project to nail it this time :-)

IMPORTANT - Using '@amp;'

You want to be really careful when you are using & in code, reason being is that sometimes it can be interpreted as an AND in code and can cause some unexpected things to happen. To keep it safe, you're going to want to use '&' Check this page for more information: https://www.w3schools.com/html/html_entities.asp

IMPORTANT - Using alt

You should consider adding an alt attribute to the images, that way if any of the images don't load for some reason, you don't get the broken link icon, rather the text you specify in alt will be displayed, more info here: https://www.w3schools.com/tags/att_img_alt.asp

IMPORTANT - Missing classes

https://github.com/brony9tynine/prj-rev-bwfs-dasmoto/blob/master/Dasmoto's%20Arts%20%26%20Crafts/index.html#L14-L49

This section needs to be done with class names input and also the divs need to cover whole sections. example:

<h1>Dasmoto's Arts & Crafts</h1>

  <!-- Brushes Section -->

  <div class="item">
    <h2 id="brush">Brushes</h2>
    <img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/hacksaw.jpeg"/>
    <h3>Hacksaw Brushes</h3>
    <p>Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Available in different sizes. <span class="price">Starting at $3.00 / brush.</span></p>
  </div>

  <!-- Frames Section -->

  <div class="item">
    <h2 id="frame">Frames</h2>
    <img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/frames.jpeg"/>
    <h3>Art Frames (assorted)</h3>
    <p>Assorted frames made of different material, including MDF, birchwood, and PDE. Select frames can be sanded and painted according to your needs. <span class="price">Starting at $2.00 / frame.</span></p>
  </div>

  <!-- Paint Section -->

  <div class="item">
    <h2 id="paint">Paint</h2>
    <img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/finnish.jpeg"/>
    <h3>Clean Finnish Paint</h3>
    <p>Imported paint from Finland. Over 256 colors available in-store, varying in quantity (1 oz. to 8 oz.). Clean Finnish paint microbinds to canvas, increasing the finish and longevity of any artwork. <span class="price">Starting at $5.00 / tube.</span>
  </div>

brony9tynine / prj-rev-bwfs-dasmoto Goto Github PK

prj-rev-bwfs-dasmoto's Issues

SUMMARY

IMPORTANT - Using '@amp;'

IMPORTANT - Using alt

IMPORTANT - Missing classes

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent