brodeurlv / fastnfitness Goto Github PK

Coming from #32 :

The Body Track needs a revision.

Found in version: 0.12beta

Current behavior: Unit does not appear in body building page

Expected behavior: to appear

Step to reproduce: none.

Found in version: 0.15.2

Current behavior: At the exercise page/fragment no new exercise can be added, because it is connected within the BodyBuilding page. And only when adding a new record the actual exercise/machine is recorded as well.

Expected behavior: The exercise page/fragment should be responsible for the management of all exercises. So its natural to add a new exercise there as well. A floating button or something similar should be there and the functionality to add a new exercise for this page and the database.
This design allows to create new exercises at home before the actual training. Also this would work quite well with #30 .

There is some difficulty to implement this, because the „machines“ database (which is better called „exercises“, see #32 ) is not yet exported on its own, but is tangled within BodyBuilding csv export.
So this also effects exporting and importing.

Found in version: 0.15.2

Current behavior:
At the exercise page, when changing the name to a already used name then the two exercises get merged:
click on save button -> merge dialog -> yes

But the app crashes with clicking the backbutton on the top left corner first:
click on backbutton -> save dialog -> yes -> merge dialog -> yes -> CRASH

Expected behavior:
not crash but merge.

Step to reproduce:

Found in version: 0.15.2

Current behavior: MachineDetailsActivity is not registered in the Manifest

Expected behavior: Either it should be registered,
or if it is a parent class it should be make abstract
or it should be deleted.

Step to reproduce:

Found in version: 0.15.3

Current behavior: In the Graphs tab in Body Building page: When choosing an exercise which has less than five reps from the drop-down list and selecting display option Maximum (reps >=5), the app crashes.

Expected behavior: Displays empty graph.

Step to reproduce:

1. Body building page: create a new exercise or choose one from the list, insert less than 5 reps and press ‘Add’.
2. Go to the Graphs tab, select the exercise you added from the drop-down list
3. Select Maximum (reps >=5) option from the display drop-down list.

au restore, le graph est celui de SUM alors que c'est MAX qui est selectionné.

Pourtant le changement de machine et le zoom fonctionne.

Found in version: 0.12

Current behavior: see title

Expected behavior: see title

Step to reproduce:

Found in version: 0.11

Current behavior: When All is selected, after an issue in retrieving the Date, the display can be very long

Expected behavior: A quick display

Step to reproduce: Wait for long, then restore the application

I had problems to clone this project correctly inside Android Studio and build it without errors.
In the Readme there should be a section explaining how to develop the code (for others).

On the Body Building tab and when exporting, some terms should be renamed:

poids -> weight
repetition -> reps
serie -> sets
and maybe: machine -> exercise (because then its the same with cardio export? see below)

Same for the profile export:
table, id, poids, date
poids -> weight

Why is the order different from the bodybuilding table export? Should be the same: table, id, date, weight

The Cardio export reads:
table, id, date, exercice, duration, distance, profil_id
So there is a spelling mistake:
exercice -> exercise

Found in version: 0.15.2

Current behavior: Exercise Favorite flag can only be set in the Machine details.

Expected behavior: Being able to set a Exercise as favorite directly from Exercise List

Im trying to build it actually with Android Studio.

Or what was used for it?

Also which java Version is needed?

Getting this errors:

1. error: resource xml/provider_paths (aka com.easyfitness:xml/provider_paths) not found.
   Message{kind=ERROR, text=error: resource xml/provider_paths (aka com.easyfitness:xml/provider_paths) not found., sources=[C:\xxx\fastnfitness-master\app\build\intermediates\manifests\full\debug\AndroidManifest.xml:74], original message=, tool name=Optional.of(AAPT)}

@brodeurlv

Found in version:

Current behavior:

Expected behavior:

Step to reproduce:

Found in version: 0.12

Current behavior: nothing. Music can only be played from the beginning

Expected behavior:

Step to reproduce:

Found in version: 0.11

Current behavior: Error on compilation "fragment-inner-class-should-be-static"

Expected behavior: no Leak :)

Step to solve:
http://stackoverflow.com/questions/15571010/fragment-inner-class-should-be-static

Found in version: 0.16.1

Expected behavior: Click on an old record to duplicate data to the current record

Found in version: 0.11

Current behavior: 2016-12-31

Expected behavior: 31/12/2016

Step to reproduce:

Found in version: 0.15.2

Current behavior:
When there are many exercises in the exercises page it is difficult to find the one you're looking for to edit it.

Expected behavior:
So some function for filtering or searching for the exercise page would be nice. I guess, something like the exercise completion from the Body Building page (when typing in the exercise field) is sufficient.

Found in version: 0.12

Current behavior:

Expected behavior:

Step to reproduce:

Found in version:
0.16.1

Which license does fastnfitness have exactly?
@brodeurlv

Found in version:0.12 beta

Current behavior:

Expected behavior:

Step to reproduce:
create profile
Import data
Go to profile
Create profile

Found in version: 0.11

Current behavior: UI is flat

Expected behavior: UI with cardview

Found in version: 0.13

Current behavior:

Expected behavior:

Step to reproduce:

Found in version: 0.11

Current behavior: No table header

Expected behavior: Add header. No need for sort.

Found in version: 0.11

Current behavior: No mention of this Chronometer

Expected behavior:
https://github.com/antoniom/Millisecond-Chronometer

I dont know if you want this, but.. all unnecassary casts should be deleted.

see here: https://stackoverflow.com/questions/44902651/no-need-to-cast-the-result-of-findviewbyid

or here: https://stackoverflow.com/questions/45092494/android-o-casting-to-findviewbyid-not-needed-anymore?noredirect=1&lq=1

Found in version: 0.16.1

Current behavior: Cardio and Fonte and Record do not have a proper hierarchy. It has to be reorganised using Interface.

Found in version: 0.12

Current behavior:

Expected behavior:

Step to reproduce:

Found in version: 0.12

Current behavior: Not very friendly UI. Differentiate Profile info and Body info

Expected behavior:

Step to reproduce:

For now we have two categories:

• Body Building
• Cardio (Beta)

The Body Building exercises are described with: "Repetitions" and "Weight". (And multiple ones can concatenated with "Series".)
The Cardio exercises are described with: "Distance" and "Duration".

But there are other exercises, which require different types of descriptions, like:

• Only Distance
• Only Duration
• Only Weight
• Only Reps
• Weight and Distance
• Weight and Duration
• Reps and distance
• Reps and Duration
• (And of course all other combinations)

The App FitNotes defines these types at every exercise (on the exercise level) and not for the whole category as it is done in FastnFitness. I don't know which method is better, but the fact that the Cardio exercises are not visible in the "Exercises" tab/page is not very nice. The Exercises page should contain all exercises, or should'n it?

Personally, I really miss the type "Reps and Duration" for doing callisthenics exercises, which often are static hold exercises. For that I would really like to help, but this needs discussion, because there are multiple ways to implement:

1. Add a new category: callisthenics (beside Body Building and Cardio (Beta)), where every exercise has "Reps and Duration" as its type.
2. Combine the two categories: "Body Building and Cardio (Beta)" to one (Maybe: "Workout"?). Then every exercise has its own type as in the list from above, which automatically opens when selecting an exercise.

Number 1. has the problem, that you would propably need even more categories in the future. Also this would (under certain circumstances) duplicate code multiple times.
I favor Number 2. Because for now the Cardio is still in Beta and the app is not this big to incorporate such a change. Maybe Number 2 sounds like it is way more complicated, but I guess it would even simplify the UI. Maybe this approach would be better with #30 and often a workout session does not consist of only Body Building exercises only with weight but maybe contain multiple forms of exercises, like cardio for warming-up and stretching exercises (inside the same workout)

Other opinions?

observed in 0.15.2

Found in version: 0.11

Current behavior: Only 3 buttons. Not possible to see all the graph

Expected behavior: Having 4 buttons so that we can see all the graph

Step to reproduce: N/A

Found in version: 0.12beta

Current behavior: wrong format

Cacher la date.
Mettre une option: more option en bas

Example:
1-You select an Exercise
2-You select a type of guided session (Physical maintenance, New max,...) and maybe ask some parameters
3-It creates automatically a set of exercises where either you check if you did it, else you correct it.

Found in version: 0.11

Current behavior: You only see Records and beginning of Graph

Expected behavior: See all tabs title in the screen

Step to reproduce: NA

Found in version: 0.15.2

Current behavior:
In the Body Building page: When at least two letters in the exercise field (Enter exercise name here) are entered, then a window pops up with the corresponding exercises, which have these letters in their name. When clicking on an exercise with an image, the text is transfered in the exercise field, but the image is not taken over into the round image on the left to the exercise field.
Only when using the list on the right to the exercise field it works.

Expected behavior:
Image should be taken over

Step to reproduce:
Follow instructions above.

MP3 bar reappears even if set to be hidden in settings menu

Found in version: 0.11

Current behavior: Only body measures is weight

Expected behavior: Add biceps, leg, chest measures

Found in version: 0.11

Current behavior: Just the date is available

Expected behavior: Date + Time

Step to reproduce: NA

Found in version: 0.11

Current behavior: No random play possible

Expected behavior: Add new button in MP3 bar

Found in version: 0.12

Current behavior: window above everything

Expected behavior: possibility to hide the window

Step to reproduce:

Found in version: 0.14.6
Current behavior: Not all data are exported/imported
Expected behavior: All data should be exported/imported

@EGUltraTM, I opened this bug to track your remark on the CVS export.
Did you work on this topic or do you need help to fix this ?

Found in version: 0.15.2

Current behavior: Exercise details can only be edited in Exercise page.

Expected behavior: Could be set directly in the Exercise list by clickinng on the exercise.

Found in version:
latest commit: 1e7b5df

Current behavior:
After starting and cloning the repo new and try to build it with Android studio I get the following error:

Failed to resolve: support-core-utils

Expected behavior:
It should build without problems and without user interference!

Step to reproduce:
Clone an build

Split of #32 but addressing only CSV.

Same for the profile export:
table, id, poids, date
poids -> weight

Why is the order different from the bodybuilding table export? Should be the same: table, id, date, weight

The Cardio export reads:
table, id, date, exercice, duration, distance, profil_id
So there is a spelling mistake:
exercice -> exercise