Code Monkey home page Code Monkey logo

blc-paypal's Introduction

blc-paypal's People

Contributors

austinmrooke avatar broadleaf-infrastructure avatar ckittrell avatar danielcolgrove avatar dmyroniuk avatar elbertbautista avatar jefffischer avatar jerry77oz avatar jfleschler avatar jfridye avatar ktisdell avatar munnja001 avatar nathandmoore avatar phillipuniverse avatar priyeshgpatel avatar riteshadhikari17 avatar samarthd avatar tleffert avatar vpenumatsa12 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

blc-paypal's Issues

Fix Deprecated methods on develop

Broadleaf 2.3.0 has deprecated PaymentResponseItem.setAmountPaid(Money) which we are using in all of the overridden methods from PaymentModule. This should be changed to instead use PaymentResponseItem.setTransactionAmount(Money)

PayPal security update: TLS 1.2 and HTTP/1.1 Upgrade - SSLHandshakeException

With PayPals' upgrade to TLS 1.2 only connections for their NVP API endpoints:
An upgrade is necessary for implementations still on Java 7 (which uses TLS 1.1 by default) in order to explicitly set the v1.2 protocol.

Information about the upgrade here:
https://www.paypal-knowledge.com/infocenter/index?page=content&widgetview=true&id=FAQ1914&viewlocale=en_EN

The test sandboxes were converted to accept TLS v1.2 on Jan 19, 2016:
http://stackoverflow.com/questions/34963083/paypal-sandbox-api-javax-net-ssl-sslhandshakeexception-received-fatal-alert-h

Those that do not upgrade to the next release of the blc-paypal module (2.6.4-GA) - will receive the following error:

javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure
    sun.security.ssl.Alerts.getSSLException(Alerts.java:192)
    sun.security.ssl.Alerts.getSSLException(Alerts.java:154)
    sun.security.ssl.SSLSocketImpl.recvAlert(SSLSocketImpl.java:1959)
    sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:1077)
    sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1312)
    sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1339)
    sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1323)

PayPal Express refuses transaction when there is an offer on the order.

Module: Broadleaf-paypal:2.6.0-GA
Broadleaf Version 3.1.3-GA

The paypal express module cannot successfully complete a transaction when there is an offer on the order (It works fine when the offer is on an order item). The error message from pay pal is: The totals of the cart item amounts do not match order amounts.

Steps to reproduce:

  1. Create an offer for a discount on an order.
  2. Add a qualifying item to your cart
  3. Add the offer code
  4. complete checkout on heat clinic
  5. Paypal payment is refused.

Full error message
[TRACE] 16:44:34 PayPalExpressHostedServiceImpl - Request to PayPal Express Checkout Hosted Endpoint with raw response: TIMESTAMP=2014-12-03T16:44:34Z&CORRELATIONID=a51dd80fe54d7&ACK=Failure&VERSION=78.0&BUILD=14086142&L_ERRORCODE0=10413&L_SHORTMESSAGE0=Transaction refused because of an invalid argument. See additional error messages for details.&L_LONGMESSAGE0=The totals of the cart item amounts do not match order amounts.&L_SEVERITYCODE0=Error

Update develop-ms branch so that it's aligned with latest microservices patterns

Description/Context

Context from @nathandmoore via Slack:
"blc-paypal is for their v1 APIs. It’s likely what existing clients who migrate to Microservices will want to use since they will currently be using those APIs. blc-micro-paypal integrates with the v2 APIs, tho still needs subscription/billing integration. So I think we still want to keep blc-paypal up to date."

This module (blc-paypal) needs to be updated so that it is aligned with the latest expectations from PaymentGatewayCommon. Our overall expectation is that this will require refactoring to how various pieces are structured, but that the underlying functionality can remain untouched.

TODOs

  • Update the PaymentGatewayCommon dependency to use the latest version
    • Possibly restructure pom.xml to match the latest dependency management patterns (see APS as an example)
  • Work through compilation & runtime issues
  • Ensure that the PaymentResponse's properties are sufficiently populated
    • Pulling data from the PaymentRequest
    • Any new properties that should be populated
  • Test integration to validate that everything works as expected

Commerce Next JS Starter

Compilation Error on develop

Version 2.4.0 (targeting Broadleaf version 2.3.0) currently does not compile because of methods introduced in the PaymentModule interface.

Because of the introduction of these new methods, this also changes what methods you should actually be overriding. For instance, payment modules should no longer override authorize and instead should override processAuthorize. This will require a refactoring of all of the payment methods that are supported in this module.

Checkout with address to Netherlands or Singapore fails

Error given is:
[TRACE] 14:24:50 PaymentGatewayAbstractController - An exception was caught either from processing the response and applying the payment to the order, or an activity in the checkout workflow threw an exception. Attempting to mark the payment as invalid and delegating to the payment module to handle any other exception processing. The error caught was: id to load is required for loading : java.lang.IllegalArgumentException: id to load is required for loading

Both countries have been loaded into the db from load_i18n_countries.sql

I can send by email the paypal return traces. It is possible this affects more countries.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.