brightify / reactant Goto Github PK

This a subject to further discussion.

All of these functions can be easily coded (on one line even), saving no space. Reactant as an architecture doesn't need these methods included.
first(where:) is now actually a part of Swift.
take(until:) is just prefix(while:).

The implementation could be like this:

public final class TypedControllerRootViewContainer<CONTROLLER>: ControllerRootViewContainer

public class ControllerRootViewContainer: UIView, Configurable

It would allow switching in styles in Configuration like this:

controllerRoot = { view in
    if view is TypedControllerRootViewContainer<LoginController> { ... }
}

This OptionSet parameter will allow for shared options (if, in the future, there are added more options to the initializer, this is reasonable) and easier initializing, compare:

let tableView = PlainTableView<FiendCell>(reloadable: false, automaticallyDeselects: false, swipeToRemove: true)

to

let tableView = PlainTableView<FriendCell>(options: [.reloadable, .toggleSelection, .swipable])

Another plus is that some libraries have quite customizable initializers that contain lots of Bool parameters, some with default values, but when you want to only use it for a simple task, going through the init can be quite tedious. Luckily, we aren't at that stage, yet, but when we get there, it's going to be too late because it would break too much code.

The downside is that I don't think you can have any default parameters with OptionSets. I mean yeah, you can set them but if the user wishes to turn off the default option, it would require an anti-option that would counter the normal one. Not sure if there's any other way.

This will make navigation through code easier as well as allow the programmer to quickly change the current font weight by steps without having to look it up.

Supper excited about Reactant. Is there any plan to add android support?

Problem is in TableViewCellWrapper.swift:

    public override func setHighlighted(_ highlighted: Bool, animated: Bool) {
        tableViewCell?.setHighlighted(isSelected, animated: animated)
    }

there should be highlighted instead of isSelected.

This is quite useful when working with our stack and UIStackView.

extension UIView {
    @discardableResult
    public func removeSubviews() -> [UIView] {
        let subviews = self.subviews
        for subview in subviews {
            subview.removeFromSuperview()
        }

        return subviews
    }
}

Suggested approach is to use RxSwift.BehaviorRelay instead.

Component.swift file, using unowned can result in a crash in case self is deinitialized (e.g. in a Observable subscription when not disposing it on its deinit).

This is needed to make the listener work when presenting from navigation, but expecting result in controller presented in UINavigationController.

extension UINavigationController: DialogDismissalListener {

    public func dialogWillDismiss() {
        if let listener = topViewController as? DialogDismissalListener {
            listener.dialogWillDismiss()
        }
    }

    public func dialogDidDismiss() {
        if let listener = topViewController as? DialogDismissalListener {
            listener.dialogDidDismiss()
        }
    }
}

The resources used are not freed after View Controller's dismissal.

When overriding actions in ViewBase error occurs and compiler informs that "Property does not override any property from its superclass" unless RxSwift is imported. It would be nice to solve it by adding a typealias for Observable.

This should be fully customizable with Configuration.

Styles either shouldn't be static, or they should receive Configuration as input to allow easy styling.

We should also look at https://github.com/inloop/Styles to see if it might be integrated.

Default should default to true, but still be changeable.

It's inconsistent.

Fix here: 663a365

This is actually a useful feature that saves time and is not part of Swift itself right now.

UIButton should not be subclassed.

Currently there is only dequeueAndConfigure(identifier:row:factory:model:mapAction:) which doesn't allow the developer to specify the section number.

This concerns, but is not limited to Tutorial 1: Reactant Notes.

At ComponentDelegate.swift:84 we have this:

public weak var ownerComponent: COMPONENT? {
    didSet {
        needsUpdate = stateStorage != nil
    }
}

If I understand the implementation correctly, we want to set needsUpdate to true if the component has a componentState, why isn't then this variable used?

public var hasComponentState: Bool {
    return stateStorage != nil
}

The bug is in afterInit.