Code Monkey home page Code Monkey logo

core's Introduction

core

core's People

Contributors

bassondag avatar jszwedko avatar pltaylor avatar therebelrobot avatar

Stargazers

 avatar

Watchers

 avatar  avatar

core's Issues

deprecate `coreLead` role

@therebelrobot commented on Wed Apr 20 2016

Description

I was being over-ambitious with user roles when I first set it up. There is no current use case differentiating core from coreLead at the moment.

Files

  • config/passport.js
  • models/Users.js
  • seeds/development/Users.js

Tasks

  • Remove all references to coreLead from codebase.

Github auth fails when using https

The following error occurs when you use https:// for both the brigade:url value and the callback value on github

500 AuthorizationError: The redirect_uri MUST match the registered callback URL for this application.

If both of those values are set to http:// and the website is accessed using only http the authorization completes no problem.

Can't create new project

Not sure what the issue is, as the error message I receive is [object Object], unfortunately.

screenshot-codeforsf-cantcreatenewproject-screenshot_2017-11-09_01-05-41

[CRITICAL] Export DB button kills entire application

Steps to reproduce:

  1. Log in as admin
  2. Go to Manage Brigade
  3. Select Download DB Backup button at bottom of page

The request will fail, and if you go to the site outside of that, you'll get an application error

Relevant logs:

Jan 26 15:06:31 sfbrigade heroku/web.1:  State changed from up to crashed 
Jan 26 15:06:31 sfbrigade app/web.1:  /app/node_modules/mongodb-collection-dump/node_modules/mongodb/lib/mongodb/mongo_client.js:423 
Jan 26 15:06:31 sfbrigade app/web.1:                throw err 
Jan 26 15:06:31 sfbrigade app/web.1:                ^ 
Jan 26 15:06:31 sfbrigade app/web.1:  TypeError: Cannot read property 'collection' of null 
Jan 26 15:06:31 sfbrigade app/web.1:      at /app/node_modules/mongodb-collection-dump/index.js:26:24 
Jan 26 15:06:31 sfbrigade app/web.1:      at /app/node_modules/mongodb-collection-dump/node_modules/mongodb/lib/mongodb/mongo_client.js:420:15 
Jan 26 15:06:31 sfbrigade app/web.1:      at _combinedTickCallback (internal/process/next_tick.js:67:7) 
Jan 26 15:06:31 sfbrigade app/web.1:      at process._tickCallback (internal/process/next_tick.js:98:9) 
Jan 26 15:06:31 sfbrigade app/web.1:  make: *** [start] Error 1 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! Linux 3.13.0-105-generic 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! argv "/app/.heroku/node/bin/node" "/app/.heroku/node/bin/npm" "start" 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! node v6.9.1 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! npm  v3.10.8 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! code ELIFECYCLE 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! [email protected] start: `make start` 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! Exit status 2 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR!  
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! Failed at the [email protected] start script 'make start'. 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! Make sure you have the latest version of node.js and npm installed. 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! If you do, this is most likely a problem with the brigadehub package, 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! not with npm itself. 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! Tell the author that this fails on your system: 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR!     make start 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! You can get information on how to open an issue for this project with: 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR!     npm bugs brigadehub 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! Or if that isn't available, you can get their info via: 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR!     npm owner ls brigadehub 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! There is likely additional logging output above. 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR! Please include the following file with any support request: 
Jan 26 15:06:31 sfbrigade app/web.1:  npm ERR!     /app/npm-debug.log 
Jan 26 15:06:32 sfbrigade heroku/router:  sock=backend at=error code=H18 desc="Server Request Interrupted" method=GET path="/api/db/backup?token=[redacted]" host=codeforsanfrancisco.org request_id=[redacted] fwd="[redacted]" dyno=web.1 connect=0ms service=521ms status=503 bytes= 
Jan 26 15:06:32 sfbrigade heroku/web.1:  Process exited with status 1 

Checkin Count API call is failing with 500 Error

installation: codeforsanfrancisco.org
relevant logs:

Jan 26 14:26:55 sfbrigade app/web.1:  TypeError: Cannot convert undefined or null to object 
Jan 26 14:26:55 sfbrigade app/web.1:      at req.mrt.result.req.mrt.result.map (/app/node_modules/brigadehub-core/helpers/mortimer/checkinResource.js:14:23) 
Jan 26 14:26:55 sfbrigade app/web.1:      at Array.map (native) 
Jan 26 14:26:55 sfbrigade app/web.1:      at /app/node_modules/brigadehub-core/helpers/mortimer/checkinResource.js:12:39 
Jan 26 14:26:55 sfbrigade app/web.1:      at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5) 
Jan 26 14:26:55 sfbrigade app/web.1:      at next (/app/node_modules/express/lib/router/route.js:131:13) 
Jan 26 14:26:55 sfbrigade app/web.1:      at req.(anonymous function).query.exec (/app/node_modules/mortimer/lib/Resource.js:524:24) 
Jan 26 14:26:55 sfbrigade app/web.1:      at Query.<anonymous> (/app/node_modules/mongoose/lib/query.js:2180:28) 
Jan 26 14:26:55 sfbrigade app/web.1:      at /app/node_modules/kareem/index.js:177:19 
Jan 26 14:26:55 sfbrigade app/web.1:      at /app/node_modules/kareem/index.js:123:27 
Jan 26 14:26:55 sfbrigade app/web.1:      at Promise.all.then (/app/node_modules/brigadehub-core/models/Checkins/index.js:39:5) 
Jan 26 14:26:55 sfbrigade app/web.1:      at process._tickCallback (internal/process/next_tick.js:103:7) 
Jan 26 14:26:55 sfbrigade app/web.1:  GET /api/checkins?date__gt=1484951199740 500 98.443 ms - - 

Will pull a copy of the checkins db to inspect for malformed data.

Hide "Fetch users from SFBrigade" for non-authorized users

@davidcarvel commented on Wed May 25 2016

Description

The "Fetch users from SF Brigade" button is on the Manage Users page. Right now, this is shown to every user. This should only be shown to the superuser role.

Screenshots

image

Files

To Reproduce

From Home > click on your profile in upper right > Manage Users

Tasks

Remember to use helpful labels and milestones. If you use the "help wanted" label, Code for America will promote it widely.


@therebelrobot commented on Wed Jun 22 2016

All syncing buttons have been moved into the manage brigade page, which is only accessible via superadmins. This will help with that issue, but there needs to be a better solution for this. Keeping open to build in proper handling of when superadmins are not admins over github org.

Brigade model is uuuuuuugly and needs to be cleaned

When taking inventory for brigadehub/theme-admin-c4sf#4, the underlying data model has been ducttaped together, with duplicate info and info that should never be in there. This needs to be refactored to better reflect the data that is specific to the brigade alone, namespaced and cordoned off for different uses (theme settings, auth settings, general info, etc.)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.