Code Monkey home page Code Monkey logo

Comments (7)

hoegertn avatar hoegertn commented on July 30, 2024

1.2.4 is the latest version. What changes are in master, that fix it?

from alexa-skill-test-framework.

rroobb avatar rroobb commented on July 30, 2024

Sorry, the master I was downloading is this one: https://github.com/bdelee/alexa-skill-test-framework/tarball/master

I found the issue in line: https://github.com/BrianMacIntosh/alexa-skill-test-framework/blob/master/index.js#L495

from alexa-skill-test-framework.

hoegertn avatar hoegertn commented on July 30, 2024

I am not sure what the broken behavior is. I understand that you want the withSessionAttributes to take precedence over the real session attributes in the sequence flow. Is this correct? Can you elaborate on the use case?

from alexa-skill-test-framework.

rroobb avatar rroobb commented on July 30, 2024

The broken behavior is that I'm not able to override a session attribute that is already set. Unless you have a reason of having that check, I created the pull request: #42

from alexa-skill-test-framework.

hoegertn avatar hoegertn commented on July 30, 2024

The idea behind this is to prefer session attributes set by the skill under test in a previous step instead of overwriting them. But your proposal is equally valid.

from alexa-skill-test-framework.

hoegertn avatar hoegertn commented on July 30, 2024

@dnetoMOB what do you think?

from alexa-skill-test-framework.

rroobb avatar rroobb commented on July 30, 2024

Unit tests should be deterministic, If you don't want to set a session attribute at one step, you can simply remove it from withSessionAttributes.

from alexa-skill-test-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.