Code Monkey home page Code Monkey logo

Comments (10)

hoegertn avatar hoegertn commented on July 30, 2024

Hi,
this is on my agenda and I will try to implement a solution this week.

see #17

from alexa-skill-test-framework.

eemmzz avatar eemmzz commented on July 30, 2024

Ah I didn't spot that issue somehow. Need better glasses. Thank you for the quick reply 👍

from alexa-skill-test-framework.

hoegertn avatar hoegertn commented on July 30, 2024

@eemmzz can you please test and review the feature I added to the master branch? This should provide the requested functionality.

from alexa-skill-test-framework.

eemmzz avatar eemmzz commented on July 30, 2024

@hoegertn thank you, I'll give it a go tomorrow

from alexa-skill-test-framework.

eemmzz avatar eemmzz commented on July 30, 2024

We had a look at the changes, and this has helped us for some initial testing but we had some extra feedback:

  • Cant add more than one resolution due to the template creating an array of size one
  • Cant do any tests around when status code is false since it's hardcoded as 'ER_SUCCESS_MATCH'
  • Slot Id is mandatory although in reality it's actually an optional value and can be null
  • In the future if amazon change the structure of the resolution object it may cause a delay in waiting for the test framework to be updated.

from alexa-skill-test-framework.

hoegertn avatar hoegertn commented on July 30, 2024

Thanks for the feedback:

  • I will have a look at some ways to solve this
  • Will fix that
  • would it be ok to just provide null as an argument?
  • You can still set the resolutions object directly on the request in your test code.

from alexa-skill-test-framework.

eemmzz avatar eemmzz commented on July 30, 2024

Allowing us to set it as null would be fine. And ah ok regarding setting the object directly on the request. Would it be worth updating the examples to include slot resolutions?

Also any idea when this will be published to npm?

from alexa-skill-test-framework.

hoegertn avatar hoegertn commented on July 30, 2024

Updating the examples sound good. Would you mind creating a PR for this?

I'm currently on holiday with poor wifi. Will release to npm when I am back on Wednesday.

from alexa-skill-test-framework.

eemmzz avatar eemmzz commented on July 30, 2024

Created the following PR #22

from alexa-skill-test-framework.

hoegertn avatar hoegertn commented on July 30, 2024

added the ER_SUCCESS_NO_MATCH case and the possibility to add multiple resolutions.

Published as version 1.1.1

from alexa-skill-test-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.