brian-girko / alarm Goto Github PK

The seconds are sometimes formatted as a single digit instead of always being 2 digits. I noticed this immediately after pressing start with a 30 minute timer. Before it rolls over to 29:59, it is briefly 30:0 instead of 30:00 as it should be.

Thank you for this great and useful extension , please implement an option for opening the extension in a new separate pop-op window. will be much more usable and in operating systems like Chrome OS , user will be able to use it all the time not just in browser and when browser is in front.

Like this extension :

Thanks a million.

Your alarm page at https://add0n.com/alarm.html has github links to your audio joiner project instead of to this one. You might want to change those. Looks like a copy-paste error.

For example, under "Need Help" you have this:

To report more bugs or submit a new bug please visit https://github.com/brian-girko/audio-joiner/

Pause is mistakenly spelled Puause

Thanks for making this extension, and for publishing the code on Github!

I'd like to make a suggestion for a feature that I haven't seen so far: it would be great if alarms could be ordered by time. I find that as I add more than a handful it becomes an O(N) scan through all of them to find one (since only 3-4 can be displayed in the restricted pop-up) and it would be easier if they were kept in order.

As a workaround, I use Inspect element on the extension, navigate to the Console, and run:

function getTime(t) { return t.hours * 60 + t.minutes; }
function cmpTime(a, b) {
  const at = getTime(a.time);
  const bt = getTime(b.time);
  return (at < bt ? -1 : at > bt ? 1 : 0);
}
chrome.storage.local.get('alarms', function(res) {
  const sorted = res.alarms.sort(cmpTime);
  chrome.storage.local.set({alarms: sorted}, out => console.log('Sorted', sorted.length, 'alarms'));
});

Which re-orders them by time.

This could also be an option in the settings.

Hi Brian,

I recently updated the two browsers I use regularly – Brave and Chrome – and both are now using Chrome version 91. Starting with this update the CSS in the pop-up is pretty messed up; here is what it looks like now:

There seems to have been some recent changes to the way CSS works in these popups. I actually experienced it myself a few days ago with a different extension I've been working on: in my case the issue I encountered with this update was that @media rules would no longer apply in extension pop-ups. So I had a rule with @media (min-width: 400px) { which was applying on pop-ups larger than 400px, and when I upgraded it no longer did. I had a quick look at your CSS file and didn't see any such rules, but it's likely that some other change in this build also caused the UI to break for your extension.

There were some changes related to flexbox in Chrome 90, but I'm pretty sure I was using Chrome 90 without issues, although I'm not 100% sure. These were also in the debugging tools, so not really something you'd expect to break the main feature, but at this point I don't really have another explanation.

I did find one way to fix it temporarily: by inspecting the pop-up and selecting

<div data-id="content" hbox flex="1">

If I remove hbox then the content becomes somewhat better, temporarily. Clicking on Stopwatch and Timer I can see that these two categories are still messed up, though.

Hope it helps!

Was it possible to set a one-time alarm for, say tomorrow/another day than today?

Please add a time zone setting to the clock so that we can set alarms based on a particular timezone. It's convenient for trading and for setting alarms when news comes out.