braytonstafford / farser Goto Github PK

See the image below.

The ordering of the MSH segment seems very hit or miss. Making a small edit and removing it sometimes fixes it. I saw this issue in another Segment but it seems very repeatable using the sample messages.

I have tried this with the latest Safari and Chrome on Mac OS X 10.11.4 (beta 2).
Safari seems to have the MSH segment messed up, Chrome seems to have a bunch of other segments messaged up. See the additional screen shots here:

Hello,

First of all nice work for Farser, that's very usefull.

I ran into an error though, when using "Version Id" field of "MSH" segment, with a value like "2.5^FRA^2.6", nothing happens.

In this case, Farser tries to get some infos from
"https://hl7.cc/api/segment?fieldIndex=5&messageType=ADT%5EA03%5EADT_A03&messageVersion=**2.5%5E**&segment=MSH", and this call fails.

The quick fix i found on my side was to change "Version Id" field from "2.5^FRA^2.6" to "2.5". This way, the http calls look like
"https://hl7.cc/api/segment?fieldIndex=5&messageType=ADT%5EA03%5EADT_A03&messageVersion=**2.5**&segment=PV1" and all works just fine.

I guess the reason why it is not working in the 1st case is that the %5E ('^') remains in the url, whereas it should not.

From what i see, a fix would be a quick change in $scope.Init(), where creating "segmentInfo" object, changing
from "messageVersion: $scope.message.split('\n')[0].split('|')[11]"
to "messageVersion: $scope.message.split('\n')[0].split('|')[11].split('^')[0]"

In the "Fields" section, the field number is listed along with the "Field Description"

It would be nice to have a separate column and label for "Field #", like is shown in the "Components" section.

With these now separate, it would be nice to be able to sort them individually.

whether it is safe to use .

Sample message where PID-3 had multiple repetitions. x^x^x^x^x^x~y^y^y^y^y^y
Field Repetitions separated them perfectly. But components section did not respect the repetion and produced 9 values (x,x,x,x,xy,y,y,y,y).

Recommendation, default components to populate first iteration on repeating fields and update if different repetition is selected in the Field Repetitions section.

Everything else seems to be working well for me.

Hi,
I am getting an internal server error this morning on controllers.js requests to /segment. In your own words, ya done goofed.

Thanks,
Ben Ganley

In the Component section we see

• Field #1
• Component #
• Component

It would be really helpful too have the "Component Description" display between "Component #" and "Component".

The same request would be helpful for the sub-component: showing "Subcomponent Name".

Good morning,
it would be possible to make some corrections to the CSS file, just to see the div and properly aligned titles, following the CSS file concerned and styles to be corrected:

https://hl7.cc/bower_components/angular-material-data-table/dist/md-data-table.min.css

md-data-table-toolbar > .md-title {
font-size: 20px; in 18px

md-data-table-toolbar {
align-items: center;
background-color: #fff;
box-sizing: border-box;
display: flex;
height: 64px;
padding: 0 24px; in 8px

table[md-data-table]:not([md-row-select]) > tbody > tr > td:first-child, table[md-data-table]:not([md-row-select]) > tfoot > tr > td:first-child, table[md-data-table]:not([md-row-select]) > thead:not([md-table-progress]) > tr > th:first-child {
padding: 0 28px 0 24px; 24px in 8px

if it were possible it would be even nicer to see since I use it frequently for business reasons, mainly for new additions on our application tests.

Greetings
Matthew