test failures with TestDyNeuGraph.test_visualize and TestDyNeuGraph.test_visualize_show about dyneusr HOT 12 OPEN

Hi @RuixueLiu, thanks for reporting!

Can you give me a little more information about your setup? i.e. operating system, python version.

Then, I can try to debug this as soon as possible.

from dyneusr.

Thanks for the fast response! Here is my setup:

2019-07-11T11:20:41-04:00

CPython 3.6.8
IPython 7.6.1

compiler : MSC v.1916 64 bit (AMD64)
system : Windows
release : 10
machine : AMD64
processor : Intel64 Family 6 Model 94 Stepping 3, GenuineIntel
CPU cores : 8
interpreter: 64bit

from dyneusr.

ah, I bet the issue is related to Windows, python's ascii codecs, and calls to json.dump

I will take a closer look and try to fix this as soon as possible.

Thanks again for your help (and patience!)

from dyneusr.

Okay, I think I have resolved the issue (see #5 for more about the specific changes). I am going to merge #5 now and hopefully this will quiet the tests.

Note, I don't have access to a Windows machine at the moment, so it's possible other issues remain unresolved. @RuixueLiu, you'll have to let me know if you see any other errors (but only if you feel like pulling the latest changes and running the tests again...)

from dyneusr.

Thanks Caleb! I pulled the latest change, and the tests can run successfully now!

However, I tried to run a simple case in notebook, and found another issue which i believe is due to the Windows file path convention.

I can see the index.html in the directory, and can open it from the directory manually.

from dyneusr.

Another related error:

from dyneusr.

from dyneusr.

Sorry for the delay, @RuixueLiu!

I think I resolved what I believe to be the underlying problem, but I haven't been able to test the changes properly. I should have access to a Windows OS soon, and can finish testing the changes then.

Thanks again for reporting these issues, and I apologize for the inconvenience.

from dyneusr.

hi, i am wondering if there is are any updates on this?

from dyneusr.

Sorry for the delay, again.

#6 should resolve the issue, but I still don't have access to a Windows machine, so it's possible that the changes do not fully address the issue on Windows and/or have introduced new problems altogether.

I went ahead and merged #6 to (hopefully) resolve the issue for Windows users, but again, you'll have to let me know if you are still seeing errors on your end.

from dyneusr.

Hi thanks for getting back to me. I pulled the latest changes, but now there are many test failures.

from dyneusr.

Hmm... this must be another Windows compatibility issue, because I can't seem to replicate the test failures on my local machine.

If you can provide a little more information about (or screenshots of) the failing tests, I'd be happy to help resolve the underlying issues as soon as possible.

Sorry (again) for all of the trouble, @RuixueLiu.

from dyneusr.