bpierre / esbuild-config Goto Github PK

Very nice project. Congratulations.
Would it be possible to get the configurations from the pachage.json?
Like this:

{
  "name": "package",
  "version": "0.2.0",
  "license": "MIT",
  "esbuild":  {
    "entry": "./index.js",
    "outfile": "./bundle.js",
    "external": ["react", "react-dom"],
    "loader": { ".js": "jsx", ".png": "base64" },
    "minify": true
  }
}

Hiya,

I am running MacOS on an M1 CPU, which is the arm64 architecture. I get the following error when I try to install deps that include esbuild-config.

% npm ci    
npm ERR! code 1
npm ERR! path /Users/aidan/dev/stedi/state/node_modules/esbuild-config
npm ERR! command failed
npm ERR! command sh -c node install.js
npm ERR! Unsupported platform: darwin arm64 LE

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/aidan/.npm/_logs/2021-09-27T23_17_30_176Z-debug.log

I'm not familiar enough with Rust to submit a potential PR to fix this, sorry!

Good idea!

We could even drop the package.json:esbuildConfig and check the package.json if no esbuild.config.json is present and no file path has been passed.

For the key, I think it would be safe to use "esbuild" directly, since esbuild doesn’t plan to support config files.

_Originally posted by @bpierre in htt

Would it be possible to add an "extend" property? I am trying to set up a monorepo with esbuild and this would make most common configuration very easy.

New Feature

For extra convenience (and to reduce the clutter of yet another project configuration file), add support for storing the esbuild configuration directly in the project's package.json file.

Something like:

package.json

  ...
  "esbuildConfig": {
    "entry": "./index.js",
    "outfile": "./bundle.js",
    "external": ["react", "react-dom"],
    "loader": { ".js": "jsx", ".png": "base64" },
    "minify": true
  },
  "scripts": {
    "build": "esbuild $(esbuild-config package.json:esbuildConfig)"
  },
  ...

Good idea!

We could even drop the package.json:esbuildConfig and check the package.json if no esbuild.config.json is present and no file path has been passed.

For the key, I think it would be safe to use "esbuild" directly, since esbuild doesn’t plan to support config files.

Originally posted by @bpierre in #5 (comment)