boxen / puppet-android Goto Github PK

View Code? Open in Web Editor NEW

This project forked from aafwu00/puppet-android

11.0 11.0 19.0 259 KB

Android Puppet Module for Boxen

License: MIT License

Ruby 71.06% Puppet 26.85% Shell 1.12% HTML 0.96%

puppet-android's Introduction

Boxen

Manage Mac development boxes with love (and Puppet).

Rules for Services

Run on a nonstandard port, usually default port + 1000 or 10000.
Install with a custom Boxen homebrew formula.
Suffix the Homebrew package's version, starting with -boxen1.
Run as a launchd service in the dev namespace, e.g., dev.dnsmasq.
Store config, data, and log files in $BOXEN_HOME/{config,data,log}. This will normally require customization of a service's Homebrew formula.

Sometimes it's not possible to follow these rules, but try hard.

Projects from the CLI

We use a totally awful hack to do from-the-cli project installs of projects. We create a file in "$BOXEN_HOME/repodir" called .projects, with a single line. That line is made up of projects separated by commas. We then read that into a Puppet fact in Puppet-land, and that checks for classes that match those project names, and includes them in the catalog.

We can't pass a FACTER_ env var because sudo has env_reset and we can't just modify the sudoers file due to a chicken-egg problem.

Hooks

All hooks must be in the namespace Boxen::Hook::MyThing.
All hooks must subclass from Boxen::Hook
All hooks must provide a private instance method required_environment_variables that returns an array with at least one entry.
All hooks must provide a private instance method #call.

Contributing

Use the OS X system Ruby (2.0 or newer). Run script/tests often. Open PR's. Use the CI.

Halp!

Use Issues or #boxen on irc.freenode.net.

puppet-android's People

Contributors

Stargazers

Watchers

Forkers

jfred gragera b2jrock bonty iostaf quackyduck drpain99 jdraymon vincekennedy platanus rafaelportela xdissent wikyd burnsra mmmries rogerhub mtakezawa salimane isabella232

puppet-android's Issues

allow setting the ndk version

I have an app that requires ndk r10, but currently this module sets $android::config::ndk_version to r9c-boxen1.

I'm a bit of a puppet noob so I'm not sure I can help out much with the pull request. But I'll give it a shot if you can point me in direction of an example I can follow.

build-tools location

@aafwu00 @tarebyte @fromonesrc I updated the brew formula to use the latest sdk. I was really looking to fix a problem where the build-tool zipalign was not found by the /opt/boxen/homebre/bin/zipalign script

That bin is in fact a symlink to /opt/boxen/homebrew/Cellar/android-sdk/24-boxen1/bin/zipalign and it contents is

#!/bin/bash
TOOL="/opt/boxen/homebrew/Cellar/android-sdk/24-boxen1/build-tools/21.1.2/zipalign"
exec "$TOOL" "$@"

The problem is that in the formula, the build-tools version is hardcoded (was to 17.0.0 and now is to 21.1.2) https://github.com/boxen/puppet-android/blob/master/files/brews/android-sdk.rb#L25-L27
In order to work you need to install that exact version with the build-tools class this puppet module provides

android::build_tools { '21.1.2': }

Maybe the the formula install bits that create those files should be triggered somehow when the android::build_tools class is used...

Or maybe the brew formula should explain after intalling that you need to install that version of build-tools ??

Can you think of a better solution or approach to fix this issue?

Allow Specifying Version for Extras

It'd be great to specify the version for Android Extras so that we can specify the exact version in our build files.

Incompatible with latest Java

If your own Puppetfile has:

github "java", "1.5.0"

On install of puppet-android you get a conflict as the latest is installed, but this seems to be requiring 1.1.2 any way to loosen this constraint?

packages not getting installed probably bacause of license accept issue

I have tried this module, but no package gets installed.

I think is because in the shell command that is used to install ( android update sdk --no-ui --filter ${filter}) there are some licenses to accept that puppet just ignore.

@aafwu00 have you ever had this problem? are you getting everything installed??
thanks!

Extras with numbers in the name always downloaded again

The detection of already installed extras doesn't work if the extra has a number in the name. For example extra-android-m2repository will install in extra/android/m2repository, but the regex ($subfix = regsubst($version, '^extra-(\D+)-(\D+)$', '\2')) will fail to match this, so it will look for extra/extra-android-m2repository/extra-android-m2repository.

So the regex should be a bit smarter, but I don't know what formats we can expect (I'm just a poor lonesome ops guy, not an Android dev, trying to get Jenkins under control). '^extra-(.+)-(.+)$' seems to work for me.