Code Monkey home page Code Monkey logo

bounswe2016group3's People

Contributors

acarharun avatar behiyeavci avatar ekremozturk avatar kuzux avatar muharremyesilyurt avatar sand94 avatar sinemdalkilic avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

kuzux noorahmd

bounswe2016group3's Issues

Group 9 Uml Review

REVIEW

Use Case Diagram:

  • I think you couldn't understand exactly the meaning of extends and includes keywords. According to this link, "The extending use case is dependent on the base use case; it literally extends the behaviour described by the base use case."
  • Every use case at use case diagram should describe an use case action instead of ui items like text of the content, text of the view etc.
  • Your use cases are not in the desired form, which consists of actors, description, data, stimulus, response and comments parts.
  • It looks like your guest user can login, logout, edit etc when I follow branch going to search use case.
  • Different use cases should have different names. In your project, use case 5 and use case 6 are the same.

Sequence Diagrams:

  • User, Interface, System and Database are generic. You should have more specific names.
  • You did not handle error case clearly at relation sequence diagram (doTopicsExist())

Activity Diagram:

  • Diamond symbol should be used as an if/else statement. However almost all diomands in your activity diagrams do not have if/else structure.
  • You did not show semantic tagging clearly.

Class Diagram:

  • The relations between classes are not specified with special keywords like has, defines, consists of etc.

Assignment 5 - Peer Review for Group 9

Activity Diagrams
  • In diagrams 1, 3 and 4, fork and join bar should be used for parallel activities instead of diamonds. Diamonds should be used for conditions.
  • Checking database for non-existing username and valid password on sign up is good thought.
Sequence Diagram 1
  • Class names should be specific to your project.
  • One point is unclear: What happens if there is no result? Does system take the same action as if there are results or different action like giving an error message. (system returns error message in use case and activity diagram)
Use case 4
  • Sorting by relevance popularity etc. and grouping results if there are too many is a good thought but it is unclear what grouping means.
  • I search by topic, member or tag but what do I see? Do I see member's questions or profile page or both. The description is not very explanatory.
Class Diagram
  • Class diagram is well structured, classes' properties are very detailed.
  • Hierarchy is not clear at the first glance, it can be improved by reorganizing classes' level on the diagram.

Assignment 5 - Peer Review for Group 9

  1. Use Case (4)
    --> I think the format that you used in all of your Use Cases are different from the one we discussed in class. You can go over slides that are given by instructors and see the difference.
    I do not think its wrong but if you explain Data, Stimulus, Response, and Comments in your Use Case,then there is no need to specify Pre/post conditions.

  2. Sequence Diagram (1)
    --> I think this is fine but you should a little more clarify what happens if someone click search without giving input or what happens when (input[length=0])? normally it should give nothing, give a error or like "Nothing found".

  3. Activity Diagram (all)
    -->I think that all diagrams are well drawn and well organized.
    One thing that could be given a little more emphasize is (Semantic)Tagging which i think is less clarified in your diagrams.

  4. Class Diagram
    -->I think this is fine but it could have been better if you make a general class which could the parent to both guest and user , as they have many similarities among them.

Show all users in the frontend

We have an API endpoint for that, so we should have at least an ugly-looking, proof-of-concept page that can do that (probably a simple

    with links to profiles)

Send emails from the backend

Forgot password mails, welcome mails and reports for food servers. If we do not want to host our own mail server(we probably don't), there are a lot of alternatives for sending mail. Amazon SES is a candidate.

Group9-UML Review

  1. Use Case 4
    The structure of the Use Case 4 does not follow the given format in the description. For instance, it does not specify Data, Stimulus, Response, and Comments. Pre-/post- conditions are not necessary. Instructions given in ‘Basic Flow’ are clear and they can be reshaped according to the correct structure. For example, the described steps can be put in Stimulus such as "Search request and inputs( topic, member, tag )' . At this step visuality is not important but the functionality of the system. Results of searching operation are stated in postcondition and they can be redefined as Response. It should state the response shown to the searching user. For example, 'Accept- sorted results' / 'Reject- Error message'. Sorting criteria can be expressed in Comments. In requirements, it is stated that the system would suggest related topics according to the query if the content is not found. This statement should be included in response as well. In addition, Data can also be specified.
  2. Sequence Diagram: (S.D. 1)
    Classes are too general. Interface and System should be more specific because they have to express the elements of the project. Customer should comprehend the design and these classes are the vital points.The page that user makes a search can be written instead of the Interface. In addition, System is also not very clear. Its job is not reflected in this diagram.
    Messages are clearly specified and time sequence, synchronous and asynchronous actions were considered. However it does not reflect what will be done if no result is found. It should cover the requirement which states that related topics should be suggested if no result is found. If-else diagram should also be added with related messages.
  3. Activity Diagram
    Flow of actions are not clear in some diagrams. For instance, in General Diagram and Activity Diagram #3, forking and joining are not shown. There are ‘diamond shapes’ however there is not any if/else condition. Semantic tagging is not reflected clearly.
  4. Class Diagram
    Relationship types are shown clearly. It could contain keywords such as 'composed of' . Also, Guest and Member classes contain several same properties. They could have a common parent.

Assignment 5 - Peer Review for Group 9

Use Case Diagram:

  • In your use case diagram unregistered user can login,logout, editing the profile etc. Clearly it must be impossible.
  • Your use case format is not as described in the lecture . It should has data, stimulus, response and comment parts.

Class Diagram:

  • Evertything is clear, good job guys.

Activity Diagram:

  • What does yes/no mean after diamonds? Diamonds should have some explaination like [registered] or [unregistered].
  • In Search activity diagram (and in some other diagrams) you should use fork to seperate parallel activities instead of diamond.
  • What is the role of diamond after view home page(on the left) in general diagram ? This is unnecessary.

Sequence Diagram

  • Name of entities are very generic. It should be spesific to your project.
  • What will happen if there is no result after search ? There is no information about it in the diagram. According to your project, system should give an error message.

Create Mockups

  • Mockups must address the core functionality of our project.
  • Use data that is realistic in terms of context and characteristics.
  • Our mockups must have titles and be enumerated.

Assignment 5 - Peer Review for Group 9

Use Case:

  • Your use cases are not in proper form. They should consist of “Data”, “Stimulus”, “Response”, “Comment” etc.
  • Under the use case “View a member’s profile”, “View a member’s profile page” use case seems to be identical with its parent.
  • Creating a relation use case is not found in the diagram. There exist a “Make a relation” use case under content creation but it’s extended. In this case users can only make relations when creating content.
  • Under creating new topic, Image/Video should have been an entity not an extension
  • The connection between Guest and Member leads to false interpretations on your diagram such as guests being able to log out.
  • I was not able to fit your use case “Ask question” into a case in your diagram. It could have been added separately or may be extended under a main item.

Class Diagram:

  • searchMember functions return Content. The name suggest to return Member type
  • Under function createDate, it might be a better idea to hold Date objects
  • The class hierarchy is not indicated by arrows and visibly not intuitive
  • Adding relations is between topics as indicated by addRelation() under Member class. Under Relation class there exists two Object types to be related. You might convert them to Topic types.
  • It has not been clear for me why you included a separate “Topic” class. I may be a field in a content but having an individual class seemed unnecessary

Sequence Diagram

  • When returning from entities (User, Database etc.) you’ve returned functions with parameters in some cases. It would be better to return objects or a function of the entity being returned to

Activity Diagram

  • The use of diamond is wrong on some cases. Use a vertical line when expressing multiple processes.
  • Questions should have been written on diamonds. It is not clear for what “Yes” and “No” are the answers. (e.g. in 1st diagram)

Team-Work

The need of producing software engineers with strong teamwork has been repeatedly stressed by industry worldwide. ABET includes this skill among the essential ones needed to be mastered by the students of an accredited program.

Test case for adding meal

Create test cases for meal addition by food servers. One of them should be a successful and the other be unsuccessful.

Project Name

Hey guys! Please put your suggestions for the project name here!

Replace redirects in the frontend

Apparently, placing redirects in the renderer is bad™. These functions need to be pure, so we should find a better place when we are doing the redirects (also, that emits a warning). On the plus ide, redirecting in the renderer still works, it's just a hacky way of doing so.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.