Code Monkey home page Code Monkey logo

bounswe2016group12's People

Contributors

cantunca avatar ezgitek avatar fepersembe avatar fzaero avatar heobu avatar iremzog avatar ktasyaran avatar leventbass avatar metinex avatar ns-ylmz avatar thoappelsin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

ezgitek

bounswe2016group12's Issues

Preparing the user stories

We have to prepare some (30 to 40) user stories. A friendly reminder that the user stories should have the form:
As a [type of user], I want [some goal] so that [some reason].

Doxygen improvement

  • Currently our site has little doxygen, it just shows classes.
  • Source Codes needs to be commented with style of doxygen .
  • Doxgen language should be learned by all. (its similar to javadoc)

Assignment 5 - Peer Review for Group 8

Use Case 6:

  1. I think Use case 6 have necessary requirements, only I think of was maybe we could add another post condition which is topic will be recommended to students who viewed topics with similar tags, maybe to students who viewed other topics of same teacher or followed the teacher.
  2. Also may be something could be added to preconditions about teacher reputation.( Teacher who have been reported a lot could be stopped from adding new content maybe)

Sequence Diagram 3:

  1. Class names maybe could be make better( Gui to Gui::SearchTab, application to maybe Topic::Search)
  2. There are 2 found(topics), maybe one of them could be changed to some error code.
  3. I think arrows between user and gui doesn't have to be synchronus.

Activity Diagram (1,3,4):

  • Diagram1:
    1. I think teacher shouldn't be completely seperated from student. Teacher should be able to do everything student can do(view topics and search topics are must have for teacher).
  • Diagram3:
    1. I think no result arrow should also exit the system with some action like "no topics found" .
  • Diagram4:
    1. I think "Exit" transition should be added with an action"exit topic", and other transitions should return the start (since we may wish to continue viewing topic).

Class Diagram:

  1. Maybe a class can be added for broadcasts and digests.
  2. Maybe timestamps could be added for logging

Test plan Formatting

The steps in your test plan at (https://github.com/bounswe/bounswe2016group12/wiki/Test-Plans) does not have a tabular (table like) format. As they are, your plan cannot be used for user testing.

You should have a table with the following fields.
Step #, Description, Data, Expected Result, Actual Result, Pass/Fail

When you start user testing, you will give this table to a user and they will fill the Actual Result and Pass/Fail fields.

Assignment 5 - Peer Review for Group 8

Use Case Diagram:

Use Case Diagram

  • I think there should be a class User class that includes Unregistered User, Teacher and Student. Other than that, diagram seems elaborative. In addition, use case diagram is too small that I can barely read.

Class Diagram:

Class Diagram

  • Class diagram seems neat and well prepared. Hovewer, I think classes for home page(feed), searchand suggestions can be added.

Activity Diagrams:

Activity Diagrams

  • There should be arrows returning to the start point, i.e. a user shall be able to search or view another topic before leaving the page.

Sequence Diagram:

Sequence Diagram

  • Diagrams are not neat but confusing, and also class names are ambiguous.

Assignment 5 - Peer Review for Group 8

Use Case:

Use Cases

  • Generally includes and extends are misused in use case diagram, e.g. outgoing arrows from Follow, Rate, Post on Discussion, Filter and Add Content should be extends not includes.
  • Create Topic should be an operation of Teacher, not Student.
  • Use Case 6 has necessary steps, however post conditions are not complete. A registered user can follow this newly created topic or the topic should be suggested to a registered user who follows the teacher.

Class Diagram:

Class Diagram

  • In class diagram Teacher class is shown as a subclass of User, however in use case diagram Student and Teacher are different classes and there is no User class.
  • New class for suggestions, topic or teacher, can be added.
  • Other than that, class diagram seems adequate and correct.

Activity Diagrams 1, 3, 4:

Activity Diagrams

  • Diagram 1 is not enough for a main activity diagram. There should be login for both teachers and students, if login is successful user should be redirected to his/her home page before the operations (create topic, edit topic, view profile etc.).
  • In diagram 3, entering keywords, topic/teacher name and tags should not be parallel operations. Also, sorting search results according to relevance and popularity can be added.
  • In diagram 4 all operations terminates the page, i.e. user cannot continue viewing the topic.

Sequence Diagram 3:

Sequence Diagram

  • I think diagram 3 is neat and clear. However, class names should be more precise, e.g. GUI can be SearchGUI. In addition, if topic is not found, relevant topics or tags should be listed rather than an error message.

Assignment 5 - Peer Review for Group 8

Use Case Review

Use Case 6

  1. Requirements are enough but they can be better by adding some details e.g. in the post conditions, if teacher erases/adds something to the topic, the topic should have a tag named "edited", indicating that the topic should be edited.

Sequence Diagram Review

Sequence Diagram 3

  1. If no topic is found, instead of error message, the most popular topics in the website could be showed.
    2.Class names could be better (SearchGUI instead of :GUI, for example).

Activity Diagram Review

Activity Diagram (1,3,4)

Diagram 1

i.In my opinion, the teacher should also be able to search & view topics, add & edit comments, view profile.
ii.Teacher should be able to do everything a student does.

Diagram 3

i.I didn't understand why "no result found" goes to the starting point. I think the application goes into a loop if no topic is found.

Diagram 4

i.In my opinion, features like "follow" or "rate" should not terminate the page. Only if user decides to go to next topic, the program should terminate.

Class Diagram Review

Class Diagram

  1. I cannot read the class diagram, it's too small.

Assignment 5 - Peer Review for Group 8

Review for the Use Case 6

It confuses me that the diagram relates the use case "Create Topic" with the actor "Student", but the description below indicates that the actor should be the "Teacher". There seems to be some other inconsistencies between the diagram and the description. Apart from the diagram, the descriptions look pretty good and concise.

Review for the Sequence Diagram 3

The "USER" on the diagram is likely an external actor. However, it has been indicated with a box, which usually indicates a system object (like the other three). External actors are usually indicated with a stick-figure as far as I remember from the lectures.

The two boxes on top of each other are most likely the alt box for the two alternatives, which lacks the alt operator on its top left. Also since the boxes do not extend all the way to the :DATABASE object, it looks like as if the :DATABASE object returns the topics found twice.

The system objects in a sequence diagram shouldn't be so general like Client, Server and Database as told by the Suzan Hoca during the lectures as a bad example (she had given that example as "what we should not do") and rather be more specific objects.

Other than these, the transition functions and the parameters to the functions look enough and complete, as well as the descriptions to the diagram.

(anything above this line has been done before 15:00)

Review for the Activity Diagrams

Activity Diagram 1

It is a nice diagram other than being a little cluttered with coinciding arrow lines.

The condition diamond splits into 7 arrows, two of which are grouped under "teacher" condition and the other 5 under "user" condition. I suppose that the "user" condition is a complex condition which expands into "teacher or student", which could be further clarified as so.

Activity Diagram 3

The four parallelized activities, to me, implies that all those 4 actions are required to proceed to the next step, although I think some of those 4 are actually optional actions, i.e. I should be able to search just by entering some keywords without specifying tags. I am not sure how one could distinguish between a required action and an optional action, though.

Activity Diagram 4

After taking some of those actions, like "View Rate" or "Follow Topic", user should probably return back to viewing the topic instead of terminating the "View Topic" activity.

(anything above this line has been done before 16:00)

Review for the Class Diagram

I understand that a "Teacher" class is generalized as a "User", a subclass of a "User", which should be indicated with a empty triangle-headed arrow pointing towards the "User" instead of that other symbol.

Other than that, I personally am a bit confused about the Association, Aggregation, Composition relations in a UML Class Diagram, so I am unable to make a review on those.

(anything above this line has been done before 17:10, sorry for being late)

Assignment 5 - Peer Review for Group 8

Here are my reviews on Group 8:

  • Project plan must be inside github folder for security and ease of use and update.
  • :Application is not clear on all of the Sequence Diagrams. Must be divided into smaller parts.
  • In use case diagram there is only a small difference between Teachers and Students. No need for that. Also I think they must be superclassed as "User" even if they are different.
  • There are missing parts in sequence diagrams: editing post and comment post.

Assignment 5 - Peer Review for Group 8

Class Diagram Review

Class Diagram

  • Writings are too small. Hence, I cannot make any review.

Use Case Review

Use Case

  • A precondition should be added to check for duplicate topics. But other than that, use case seems pretty solid.

Activity Diagram Review

Activity Diagram

  • Diagram 1
    • Teachers should also be allowed to search topic, view topics etc. just as the students do.
  • Diagram 3
    • Users should also be able to search topics within a timeframe.
    • ”No topics found” should not go to the starting point.
  • Diagram 4
    • View topic process should not end when a topic is viewed. A transition should be added for the system to go back to the starting point.

Sequence Diagram Review

Sequence Diagram

  • For the sake of a better understanding writings could be bigger.
  • Class names can be choosen in a clearer way.

Preparing the domain analysis document

I am quoting this:

"Please provide small descriptions of the existing applications, listing their key features, and finally, list the advantages that your system will offer compared to the features of the existing systems."

So we have to come up with sentences like "Our product is similar to [this], but only better because of [these]."

Decide on technologies

Decide on which languages and environments to use while developing front end and back end.

References

Also remember to put a reference link whenever necessary.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.