botahamec / exun Goto Github PK

In the image crate, there's an error type that looks like this:

pub enum ImageError {
    Decoding(DecodingError),
    Encoding(EncodingError),
    Parameter(ParameterError),
    Limits(LimitError),
    Unsupported(UnsupportedError),
    IoError(std::io::Error),
}

I expect it possible to see a DecodingError, but nothing else should be possible for my use. Perhaps we could find a way to make it easy to decode that. Here's the solution my project is using:

fn convert_image_decoding(e: image::ImageError) -> Expect<DecodingError> {
	if let image::ImageError::Decoding(de) = e {
		Expected(de.into())
	} else {
		Unexpected(e.into())
	}
}

let texture = image::load_from_memory_with_format(buf, format.into()).map_err(convert_image_decoding)?;

The two constructors for RawUnexpected are:

• RawUnexpected::new: takes an Error
• RawUnexpected::msg: takes a Display + Debug

I'm wondering if we'd like to change them to from_err and from_msg respectively, following the Rust API Guidelines. I used new and msg because that's what anyhow and eyre use.

An Option::unexpect method would probably be useful.

I'd like to see serde support in this crate. This would involve creating a new feature, which would be turned off by default. I can only see this being implemented for Exun. I'm open to suggestions if someone can think of a way to make it work on RawUnexpected or UnexpectedError.