bosunski / paystack Goto Github PK

As title, the PHPUnit provides two approaches about declaring test methods:

• Using the test prefix for method name. For example, public function testMethodName.
• Using the @test comment annotation to declare this methods.

And it seems that this repository has two approaches on this test folder.

After analyzing all test methods on test folder, the result is as follows:

Using the @test comment annotation has 115 times.

Using prefix-based for declaring test method has 25 times.

IMHO, I think it should be consistency and it can be easy for developers to know these methods belong to PHPUnit test methods.

Once this issue is accepted, I would be happy to work on this :).

As title, it seems that the PHP version requirements are not set correctly.

According to the composer.json, it defines "php": "^7.1.3|^7.2" on require block.

It doesn't test php-7.1 version during Travis CI build because the php-7.1 version doesn't define on .travis.yml file.