Code Monkey home page Code Monkey logo

Comments (5)

kawka-maciej avatar kawka-maciej commented on May 25, 2024 1

Works well on Safari Version 13.1.3 (15609.4.1).

from music-metadata-browser.

Borewit avatar Borewit commented on May 25, 2024

Hi @martinfoakes.

Thanks for your detailed analysis.

It was in PR #597 where the switch from Uint8Array to a ReadableStream has been made. By doing that I hoped that a file uploaded was streamed directly to the parser, rather then entirely buffered first. Also the code became a bit simpler like this.

The ReadableStream.getReader() should be compatible with Safari 10.1. I don't have a Safari browser on my system, so not super easy for me to debug. I am not sure what is the best way forward here.

from music-metadata-browser.

Borewit avatar Borewit commented on May 25, 2024

I have tried to upload a file in Safari 14.1 via browserstack.com to audio-tag-analyzer, which is using the parseBlob function. I did not experience any problem.

from music-metadata-browser.

kawka-maciej avatar kawka-maciej commented on May 25, 2024

the blob.stream is available since Safari 14.1 so it works within your tests. But for the older versions, it indeed breaks some functionality as described above:

https://caniuse.com/mdn-api_blob_stream

from music-metadata-browser.

Borewit avatar Borewit commented on May 25, 2024

Please confirm compatibility with older Safari browsers is restored in v2.5.1.

from music-metadata-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.