Comments (5)
Works well on Safari Version 13.1.3 (15609.4.1)
.
from music-metadata-browser.
Hi @martinfoakes.
Thanks for your detailed analysis.
It was in PR #597 where the switch from Uint8Array
to a ReadableStream
has been made. By doing that I hoped that a file uploaded was streamed directly to the parser, rather then entirely buffered first. Also the code became a bit simpler like this.
The ReadableStream.getReader()
should be compatible with Safari 10.1. I don't have a Safari browser on my system, so not super easy for me to debug. I am not sure what is the best way forward here.
from music-metadata-browser.
I have tried to upload a file in Safari 14.1 via browserstack.com to audio-tag-analyzer, which is using the parseBlob
function. I did not experience any problem.
from music-metadata-browser.
the blob.stream
is available since Safari 14.1 so it works within your tests. But for the older versions, it indeed breaks some functionality as described above:
https://caniuse.com/mdn-api_blob_stream
from music-metadata-browser.
Please confirm compatibility with older Safari browsers is restored in v2.5.1.
from music-metadata-browser.
Related Issues (20)
- Get rid of assert dependency
- Bug with in-browser implementation HOT 6
- Uncaught ReferenceError: exports is not defined HOT 2
- 'TypeError: this.parseReadableStream is not a function' on latest version 2.5.1 HOT 2
- Broken data in metadata result HOT 3
- Incompatibility with Webpack 5 HOT 3
- TypeError: can't access property "call", Stream is undefined HOT 9
- No title or artist metadata from URL streams HOT 4
- Add MusicSource to online demos HOT 1
- fetchFromUrl doesn't include credentials HOT 1
- Can't use this package with vite 3 HOT 9
- Source map warnings.
- Using music-metadata 7.x instead on 8.x HOT 2
- use Range header to fetch metadata instead of whole file? HOT 1
- Nuxt 3 compatibility HOT 2
- Multiple blobs at once not parsing in WebWorker in Firefox HOT 5
- Wrong "Sample-rate" in "Audio Tag Analyzer" demo
- Option to avoid parsing entire file? HOT 1
- Polyfill required with Vite 4 - Buffer is not defined
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from music-metadata-browser.