Bug with in-browser implementation about music-metadata-browser HOT 6 CLOSED

Any difference using:

import * as process from 'process/browser;

?

I'm gonna have a look at your links for the commit and the pull you merged to try and work backwards from what might have caused the behavior. I'd be happy to try and be useful/contribute. I love this library...and the code's really clean/fun to read :)

Glad you like. There is work to do if you are interested, particularly in the area of browser adaptation, or maybe I should say: the modules being more suitable universal use (Node.js + browser) with recent new features like ES modules and web stream support in Node.js. Getting feedback if we are getting rid of the shimming pain (that is what I expect from utilizing ES modules) is already helpful.

Related issues: (using bottom-up approach:)

• Borewit/peek-readable#339
• Borewit/peek-readable#353
• Borewit/strtok3#533

from music-metadata-browser.

@armenr, any improvement if you switch from v2.5.0 back to v2.4.3? The difference being 4652cae via #597, streaming instead of buffering the Blob.

from music-metadata-browser.

The cause of the issue is that something is calling process.nextTick which should be properly shimmed.

It looks likes process is not properly polyfilled.
This is the way I poly-filled things: https://github.com/Borewit/audio-tag-analyzer/blob/master/src/polyfills.ts#L41-L47
I don't directly see a breaking difference.

from music-metadata-browser.

@Borewit -

1. Thank you for your incredibly swift and thoughtful replies!
2. By reverting to 2.4.3, everything went back to running and working perfectly both in dev and in my builds

I'm gonna have a look at your links for the commit and the pull you merged to try and work backwards from what might have caused the behavior. I'd be happy to try and be useful/contribute. I love this library...and the code's really clean/fun to read :)

from music-metadata-browser.

@Borewit - I also used your example for polyfills - I changed my shim.ts file to the following:

import * as process from 'process'
;(window as any).process = process
;(window as any).global = window

import * as _buffer from 'buffer'
;(window as any).Buffer = _buffer.Buffer // note: the trailing slash is important!

THEN, I updated back to 2.5.0, and tested again...but got the same error in console

from music-metadata-browser.

As there is no clear cause, I will close this issue.

from music-metadata-browser.