bookingsync / bookingsync_application Goto Github PK

We need to update :

• rails >= 4.2
• bookingsync-engine ~> 2.1.0

to BookingsyncApplication::Admin::CommonBaseController, it should only be used in admin context

Currently there's a sign out after 10 minutes of inactivity, which might be an issue when some longer time of inactivity is expected. Increasing this value may lead to some vulnerabilities - when logging out from BS core the app would still be authenticated for longer time, maybe there should be an endpoint for keeping auth alive and making request to this endpoint every x minutes.

At least 4.1 and 4.2, appraisals maybe?

It looks like this project has way more boilerplate code that the actual code (only 2 controllers + vcr config = few dependencies), maybe we should move this to bookingsync_portal and nuke this?, no need for this extra level?

Need to extract common webhooks code from bsa apps and put in one place so all of them run the same code.

Following #21 some documentation in the ReadMe is needed