Support ES5 about odata-filter-builder HOT 5 CLOSED

Published version 1.0.0-1 with fix.

from odata-filter-builder.

Hi @jgornick.
Library distributed with es5:

1. umd:
   https://unpkg.com/[email protected]/dist/odata-filter-builder.js
2. commonjs:
   https://unpkg.com/[email protected]/lib/ODataFilterBuilder.js

Could you describe what is wrong in IE?

from odata-filter-builder.

I suppose when I'm using TypeScript and importing like:

import { ODataFilterBuilder } from 'odata-filter-builder';

My output via webpack is using the src/ODataFilterBuilder.js defined via module in package.json. This should be using the main lib/ODataFilterBuilder.js.

If I remove module then my build uses the ES5 version of the script in lib.

Thoughts?

from odata-filter-builder.

I see.
For module field, we need transpile our source to es5, with import/export declaration (https://rollupjs.org/guide/en#output-format-f-format)

As a workaround, you could include odata-filter-builder to your typescript loader, or remove module field from mainFields:

mainFields: ["main"]

Fill free to create PR.
It should be something like:

{
  "module": "es/ODataFilterBuilder.js",
  ...
  "scripts": {
    ...
    "build:es": "rollup -c -f es src/ODataFilterBuilder.js > es/ODataFilterBuilder.js",
    ...
  }
}

from odata-filter-builder.

I ended up fixing in my webpack config like:

resolve: {
  alias: {
    'odata-filter-builder': path.resolve(
      helpers.root('node_modules'),
      'odata-filter-builder',
      'lib',
      'ODataFilterBuilder.js'
    )
  }
}

However, I do agree that by default the module and/or main in the distributed package.json point to an ES5 version.

I'll try to get something together for this and submit a PR.

from odata-filter-builder.