Support for ES2015 module exports about odata-filter-builder HOT 7 CLOSED

Hey @jgornick !
Glad you're using ODataFilterBuilder!

I will fix it soon.

Have You tried esModuleInterop from typescript 2.7?
It should fix Your issue for now.
With this option your import should be:

import ODataFilterBuilder from 'odata-filter-builder';

from odata-filter-builder.

Nice! Haven't been able to upgrade yet to 2.7.x, but will give this a try when I can upgrade. If I have some time, I'll first look into providing a PR with the fix.

Thanks!

from odata-filter-builder.

Published version 1.0.0-0 with updated export:

Could be installed via

> npm install odata-filter-builder@next

from odata-filter-builder.

With ts we have one more issue:

TypeError: Class constructor ODataFilterBuilder cannot be invoked without 'new'

Mb will drop support of ODataFilterBuilder without new.

@jgornick what do You think?

from odata-filter-builder.

Externally, sure it makes sense to not support a consumer creating a new instance of ODataFilterBuilder.

Another option would be to allow the creation of new instances and then having "static" methods to create a new instance of ODataFilterBuilder:

const fb: ODataFilterBuilder = ODataFilterBuilder.and();

// or

const fb: ODataFilterBuilder = ODataFilterBuilder.or();

Thoughts?

from odata-filter-builder.

Static methods for creating (and and or) are already available
https://github.com/bodia-uz/odata-filter-builder/blob/v1.0.0-0/src/ODataFilterBuilder.js#L230-L231

But the documentation for them could be better.

Currently, doc says to use:

const fb: ODataFilterBuilder = ODataFilterBuilder();

fb.eq('x', 1);

Need to depracate old format and update doc with:

const fb: ODataFilterBuilder = new ODataFilterBuilder();
// or
const fb: ODataFilterBuilder = ODataFilterBuilder.and();
// or
const fb: ODataFilterBuilder = ODataFilterBuilder.or();

fb.eq('x', 1);

Or/And mb add factory functions to module export:

import { and, or } from "odata-filter-builder";
// import { createAnd, createOr } from "odata-filter-builder";

const fb: ODataFilterBuilder = and();
// or
const fb: ODataFilterBuilder = or();

from odata-filter-builder.

@bodia-uz This is looking awesome! I like the ability to just use and() or or() as factory methods. Awesome stuff!

from odata-filter-builder.