bnomei / kirby3-doctor Goto Github PK

https://docs.laminas.dev/laminas-diagnostics/diagnostics/

Since 2fa1cc7#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R35 you require PHP 8.1 for this plugin. However, quite some code isn’t ready for PHP 8.1 out there. Is it really required or would a minimum requirement of PHP 8.0 be enough?

Thanks for clarification!

Kirby CMS version is not most current available.

while I have the latest (at the moment) version of Kirby installed (3.6.0-RC.4)?

We have moved the project to PHP 8 as PHP 7.4 is EOL at the end of the year. Unfortunately, one dependency does not tolerate the change:

Your requirements could not be resolved to an installable set of packages.

Problem 1
- bnomei/kirby3-doctor[1.5.0, ..., 1.5.1] require zendframework/zenddiagnostics ^1.6 -> satisfiable by zendframework/zenddiagnostics[v1.6.0].
- zendframework/zenddiagnostics v1.6.0 requires php ^5.6 || ^7.0 -> your php version (8.0.13) does not satisfy that requirement.
- Root composer.json requires bnomei/kirby3-doctor ^1.5 -> satisfiable by bnomei/kirby3-doctor[1.5.0, 1.5.1].

As the plugin allows to define custom checks in the config.php file, it would be a great addition to give plugins access to that functionality as well. A thumbnail generator could check is the driver works or necessary CLI tools are available, plugins accessing third-party APIs could check whether the API keys are valid etc.

Kirby’s plugin method can hold custom parameters, the implementation could be done as simple as follows:

Kirby::plugin('my/plugin', [
  'bnomei.doctor.checks' => [
    "MyNamespace\\MyClass" => true, // enable new
  ],
]);

The Doctor class could load the checks defined by plugins pretty easily:

$pluginChecks = [];

foreach (kirby()->plugins() as $plugin) {
  $pluginChecks = array_merge($pluginChecks, $plugin->extends()['bnomei.doctor.checks'] ?? []);
}

add to must be writeable because of license

Hey @bnomei ,
Thinking about this plugin, I thought it would be awesome to let other Kirby plugins register their own Doctor checks, if installed together.
A bit like how Doctor uses Kirby Log : if plugins (and user config.php?) could extend Doctor checks, this plugin would unleash its true powers.
Any thoughts about this ?

One feature request:

Could you display the current size of the cache and media folder while showing

Cache (Files) is not exceeding set limit of 0,5x size of content.

Media-Folder is not exceeding set limit of 2x size of content.

https://github.com/k-next/plugins/issues/51
https://github.com/k-next/plugins/issues/96

https://docs.zendframework.com/zend-diagnostics/diagnostics/

you could use this tool if you have ssh access on the server.
https://github.com/psecio/iniscan

I get the following warning message,please fix this to comply with Composer V2.0:

Deprecation Notice: Class Bnomei\Interfaces\Doctor located in ./site/plugins/kirby3-doctor/classes/Interfaces/DoctorInterface.php does not comply with psr-4 autoloading standard.

It will not autoload anymore in Composer v2.0. in phar:///Applications/DevDesktop/tools/composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201

Deprecation Notice: Class Bnomei\Interfaces\Doctor located in ./site/plugins/kirby3-doctor/classes/Interfaces/DoctorInterface.php does not comply with psr-4 autoloading standard. 

It will not autoload anymore in Composer v2.0. in phar:///Applications/DevDesktop/tools/composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201