Here is a couple of suggestions on restructuring the code to enable configuration attributes (which can also be saved to databroker):

• make all the parameters from

  ophyd-basler/ophyd_basler/basler_camera.py

  Lines 53 to 63 in 0b99bc6

  	self.user_defined_name = self.camera_object.GetDeviceInfo().GetUserDefinedName()
  	self.camera_model = self.camera_object.GetDeviceInfo().GetModelName()
  	self.camera_serial_no = self.camera_object.GetDeviceInfo().GetSerialNumber()
  	self.width = self.camera_object.Width()
  	self.height = self.camera_object.Height()
  	self.pixel_level_min = self.camera_object.PixelDynamicRangeMin()
  	self.pixel_level_max = self.camera_object.PixelDynamicRangeMax()
  	self.active_format = self.camera_object.PixelFormat.GetValue()
  	self.formats_supported = self.camera_object.PixelFormat.Symbolics
  	self.payload_size = self.camera_object.PayloadSize()
  	self.grab_timeout = 5000

  components (Signal) with kind='config'. It can be done via a dedicated class, and there can be 2 classes mixed together.
• open camera on the stage method, and close it on the unstage one, don't mix the calls to the camera API in __init__ and __trigger__.
• the update_components method is not used anywhere, maybe we can remove it.
• In

  ophyd-basler/ophyd_basler/basler_camera.py

  Line 70 in 0b99bc6

  self.camera_object.StartGrabbingMax(self.exposure.get())

  the exposure name is misleading. I believe it collects up to the specified number of frames. Let's use a more accurate variable name (exposure may refer to the exposure_time/exposure_period conventionally used in the area-detector framework).

https://www.pythonforthelab.com/blog/getting-started-with-basler-cameras/

https://www.visiononline.org/userAssets/aiaUploads/File/GigE_Vision_Specification_2-0-03.pdf - for a more general approach.

We need to be able to configure a custom exposure/acquisition time for the Basler cameras via pypylon.

TODOs:

• add an option to display predefined images: https://docs.baslerweb.com/camera-emulation#displaying-custom-test-images
• take care of the failed buffers: https://docs.baslerweb.com/camera-emulation#generating-failed-buffers