Code Monkey home page Code Monkey logo

zkbnb-crypto's Introduction

zkbnb-crypto

zkbnb-crypto is the crypto library for ZkBNB Protocol. It implements rollup block circuit and supports exporting groth16/plonk proving key, verifying key and solidity verifier contract.

Getting Started

Exporting groth16 proving/verifying key, verifier contract

cd circuit/solidity;

go test -run TestExportSolGroth16  -count=1 -timeout 99999s

After this command is finished, there will be 3 generated files: zkbnb.pk_groth16, zkbnb.vk_groth16 and ZkBNBVerifier.sol

Exporting plonk proving/verifying key, verifier contract

cd circuit/solidity;

go test -run TestExportSolPlonk -count=1 -timeout 99999s

After this command is finished, there will be 4 generated files: zkbnb.pk_plonk, zkbnb.vk_plonk, zkbnb.srs_plonk and ZkBNBPlonkVerifier.sol

NOTICE: The generated proving and verifying key shouldn't be used in production environment, it's only for test purpose.

Contributions

Welcome to make contributions to github.com/bnb-chain/zkbnb-crypto. Thanks!

zkbnb-crypto's People

Contributors

cosinlink avatar forcodedancing avatar gzelda avatar keefel avatar lightning-li avatar sherlzp avatar unclezoro avatar yutianwu avatar zhangeek avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

zkbnb-crypto's Issues

FullExitNft circuit missing constraints

Describe the bug
In VerifyFullExitNftTx function, there is no match logic between tx.CreatorAccountIndex and tx. CreatorAccountNameHash. tx.CreatorAccountIndex and tx. CreatorAccountNameHash are parts of pubData, and used in L1 smart contract. If the match logic is missing, then it's possible for l2 give an invalid tx.CreatorAccountIndex.

To Reproduce
Suppose committer is malicious
Committer force to assign an invalid account index to tx.CreatorAccountIndex

Expected behavior
The match logic is removed by #24, we should add it back, and in zkbnb repository, we should modify FullExitNft tx details generation logic

StateRoot verification logic isn't correct when there are empty txs in the block

Describe the bug
When there are empty txs, block circuits ignore doing state root verification, the code:

isEmptyTx := api.IsZero(api.Sub(block.Txs[block.TxsCount-1].TxType, std.TxTypeEmptyTx))
notEmptyTx := api.IsZero(isEmptyTx)
std.IsVariableEqual(api, notEmptyTx, block.NewStateRoot, block.Txs[block.TxsCount-1].StateRootAfter)

So if malicious prover gave a wrong block.NewStateRoot in the block which contains empty txs, the circuit will also passed.

To Reproduce
Malicious prover gave a wrong block.NewStateRoot in the block which contains empty txs

Expected behavior
The block circuit should guarantee that block.NewStateRoot is correctly constructed by all txs.

Additional context
zkbnb repository should make changes for empty txs, see bnb-chain/zkbnb#203

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.