bmino / sparcpong Goto Github PK

Nodemailer is currently at version 0.7.1 due to encountering issues sending gmail messages when I originally implemented the feature. This is severely outdated compared to the current nodemailer release of 4.6.7

Acceptance Criteria:

• npm audit error relating to nodemailer is resolved
• Email functionality is not broken

Haven't had a chance to debug yet. Just posting here for tracking purposes. Fails out during the creation of a new team with the following stacktrace in the server log:

Validating if player is a part of too many teams. ReferenceError: reject is not defined at Object.verifyPlayerCanJoinById (/Users/nicholaskraftor/sparcPong/services/TeamService.js:31:28) at /Users/nicholaskraftor/sparcPong/routes/TeamController.js:29:45 at Layer.handle [as handle_request] (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/layer.js:95:5) at next (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/route.js:137:13) at Route.dispatch (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/route.js:112:3) at Layer.handle [as handle_request] (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/layer.js:95:5) at /Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/index.js:281:22 at Function.process_params (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/index.js:335:12) at next (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/index.js:275:10) at Function.handle (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/index.js:174:3) at router (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/index.js:47:12) at Layer.handle [as handle_request] (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/layer.js:95:5) at trim_prefix (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/index.js:317:13) at /Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/index.js:284:7 at Function.process_params (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/index.js:335:12) at next (/Users/nicholaskraftor/sparcPong/node_modules/express/lib/router/index.js:275:10)

When a challenge is expiring and you can't make the game, it would be nice to request an extension.

It can work just like the challenge mechanism where both parties have to agree.

After resolving a challenge, the match history will update in real time, but the score will not always reflect new matches until the page is refreshed.

This is likely due to race conditions from the socket event callbacks in teamProfileController.js

Would be nice to have a place to toss notes and setup guide for the repo, and also define the tech used and what the source/inspiration was to the file structure and coding style.

There is not an internal mechanism to schedule automated tasks such as auto-forfeiting and auto-challenging.

Sparc Pong will eventually migrate off of the Heroku platform and will require this feature.

Acceptance Criteria:

1. Application can schedule auto-forfeits
2. Application can schedule auto-challenges
3. Scheduling frequency is configurable via an environmental variable
4. Scheduling can be disabled entirely via an environmental variable
5. Scheduling framework can scale to accommodate additional tasks

Similar to the per user view, but a dashboard for all open challenges and all past matches.

• Won a match
• Opponent resolved the score correctly
• App correctly reflects win
• Email received says I lost

Issue seems cosmetic since it's just an email, but thought it was worth noting.

I have poor memory and don't want to have two bookmarks (one for the site, one for the repo)