bluehost / endurance-wp-plugin-updater Goto Github PK

Summarize the issue (briefly)
Making some updates to the bluehost plugin and finding a new warning.

Warning: First parameter must either be an object or the name of an existing class in /app/wordpress/wp-content/plugins/bluehost-wordpress-plugin/vendor/bluehost/endurance-wp-plugin-updater/Updater.php on line 90

Steps to reproduce

1. Go to plugin branch on bh plugin.
2. Turn on Debug mode
3. Install a plugin from zip
4. See/experience warning

Expected behavior
No warnings should display.

Screenshots

Bluehost Plugin Version:

• Version: 2.5.x

Browser (with version) & Operating System (with version)

• Browser: chrome
• Operating System: macOS Catalina
• Device: mac

Additional context
I think we'll want a little update here in coordination with these PRs:
bluehost/endurance-wp-module-data#18
https://github.com/bluehost/bluehost-wordpress-hub/pull/32

Summarize the issue (briefly)
WordPress 5.5 will introduce a native UI for managing plugin and theme auto-updates on a per plugin/theme basis. For plugins not hosted on the .org directory, there are a few requirements that have been documented in a recent developer note.

The main take away from that post is the no_update property is a requirement for the auto-update UI to work correctly for externally hosted plugins.

When an update is not available for a plugin, it must be added to the no_update list within the transient. This is the only way for WordPress to know that an externally hosted plugin is in fact checking for updates when there currently are none to apply, so this controls whether the auto-update toggle is displayed.

Steps to reproduce

1. Install WP 5.5 (currently in RC2) using the beta tester plugin and install either the Mojo or Bluehost plugins.
2. Head to the Plugins page
3. Notice there is no link for managing the auto-update status for the plugin.