Code Monkey home page Code Monkey logo

cs-module-project-recursive-sorting's Issues

test_in_place_merge_sort does not tests for sorting in place

Code Reference

https://github.com/LambdaSchool/cs-module-project-recursive-sorting/blob/0fd49e2dbd425875300446e6bc444d6350cf3ae9/src/recursive_sorting/test_recursive.py#L21-L34

Bug

In-place sorting means that the initially passed in array will be modified, and does not need to be re-assigned.

If the merge_sort_in_place() function creates a new array and returns it without modifying the original, this test should fail. Currently, it does not.

Fix

Call the merge_sort_in_place() function before testing, and then assertEqual() the array itself to the expected value. This should test whether the array was truly modified in place.

Fixed in PR #11.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.