bloominstituteoftechnology / c-web-server Goto Github PK

Is there a way to integrate PHP into this webserver?

hello i am programming beginer. i am first time in git hub. so if i rude, tell me please. so, is this school project? i want to contribute this project but if this is school project,,, i think only lambdaschool student can contribute this project...
can i contribute this project?

Is there a license for this material?

In net.h, we used struct sockaddr in a function prototype, but we did not include socket.h in the header file. This is dangerous IMO because if the user decides to sort (or the IDE automatically sorts) the includes in net.c, such that #include "net.h" happens before #include <sys/socket.h>, the program will not compile. For best practices, we should include socket.h in net.h, or at least forward declare the struct.

// At the top of net.h, within the include guards.

#include <sys/socket.h>

// or

struct sockaddr; // forward declare

The following section in the readme is incorrect. While you can use GET to request an HTML document, that is not necessarily a common use-case. A more common use-case for GET is to request data from a server and send that back in the response payload, typically using JSON. I think this description limits students to a box of what GET is for and is very inaccurate. Imagine someone interviewing for a company and them saying something like that. That really hurts someone's chances of nailing that job they really want, and need since they just spent $10k+ on this program.

A web server is a piece of software that accepts HTTP requests (commonly GET
requests for HTML pages), and returns responses (commonly HTML pages). Other
common uses are GET requests for images within web pages, and POST requests to
upload data to the server (e.g. a form submission or file upload).