bloombergindustry / fishtank-vue Goto Github PK

https://github.com/bloombergbna/fishtank-vue/blob/9a628995c0cefa3d7275efd4f35e4bca511f02ae/src/components/FishTankTextInput.vue#L153

We need to emit the change event of the component upward to it parent:

      changeState() {
        if(!this.close){
          this.activeState = !(this.activeState);
        }
        // emit a change event, with the new active state. the parent can use v-on:change="" to tie a function to that event
       // https://vuejs.org/v2/api/#vm-emit
        this.$emit('change', this.activeState)
      },

https://github.com/bloombergbna/fishtank-vue/blob/c5178da5aadceca8cf9561c5b07702784c61e5c9/src/components/Tag.vue#L37

Vue-popper is currently declared as a dev dependency but when installing the newest version of fishtank-vue, I get an error that vue-popper is not installed, indicating it should be promoted to a full dependency.

With Vue.extend, use this data notation:
data: function(){}

https://github.com/bloombergbna/fishtank-vue/blob/c5178da5aadceca8cf9561c5b07702784c61e5c9/src/components/Tag.vue#L32

On the Buttons documentation, add the following:

1. A visual representation of the available buttons and their possible states.
2. Clarify which button types the Gradient Button Props can be used on.
3. Add a "Default" column to the props tables. For non-required parameters describe either the default value or what happens if they're not set.
4. Refine the "Type"s. I.e. gradientStart and gradientEnd are not just strings, but hex values (or are they any valid CSS color?). Is the colorDirection one of a set of enumerated values?

https://github.com/bloombergbna/fishtank-vue/blob/c5178da5aadceca8cf9561c5b07702784c61e5c9/src/components/Tag.vue#L43-L51

Use the Vue.extend({}) notation to declaring the component:
export default Vue.extend({
//Vue script stuff goes here
})
//make sure there is a closing parentheses.

https://github.com/bloombergbna/fishtank-vue/blob/c5178da5aadceca8cf9561c5b07702784c61e5c9/src/components/Tag.vue#L68

Use the Vue.extend({}) notation to declaring the component:
export default Vue.extend({
//Vue script stuff goes here
})

https://github.com/bloombergbna/fishtank-vue/blob/c5178da5aadceca8cf9561c5b07702784c61e5c9/src/components/Tag.vue#L13