blodwynn / -vscode-.soy-language-server-client Goto Github PK

During the load or any manually started re-parse, Soy parsing runs infinitely and jumping to reference/definition is not working at all.

By turning on Develoepr Toolbar and adding some console.log into the extensions code, I found that in the parseFile function, the linenumber method sometimes returns with a null and therefore lineNr[0] is makign a JS error.

The file which causing the problem had a weird formatting and in the line of the template definition there was immediately another soy command:

{template .sometTemplageName}{locallyDefinedFunction('params')}

I suggest a change in the regular expression, which is finding the template definition token:

const templatePattern = /\{(del)?template ([\w\d.]+)([^\w\d.]).*/gm;

to

const templatePattern = /\{(del)?template ([\w\d.]+)[^\}]*\}/gm;

The syntax for soy have changed a bit in the last year. Is this extension still maintained?

If I would start sending pull requests would those get reviewed?

This works:

But adding a colon here breaks it:

Also, highlighting of comments doesn't work inside the tag any more (comment should be green here):

See PR: #12

I have a large workspace with many soy files and upon opening the first one the extension is parsing soy files for a very long time.

The current workspace isn't so big relatively (maybe hundreds of soy files) but it's still been going for many minutes.

There are library soy templates in my org that I've not even pulled in yet but honestly the highlighting and syntax warnings are enough so if my workspace is too big I wonder if I can disable those features?

Seems like it "opens" a string which is never terminated

Error message on hover reads:

[ex] {param bar kind="html"}{call .baz /}: Unnecessary closing tag for PARAM opening tag.