Code Monkey home page Code Monkey logo

Comments (4)

Aleksandra0056 avatar Aleksandra0056 commented on May 24, 2024

I want to note, that the #862 was incorrectly fixed, but I will write it here instead of creating a new issue.

The new Proton icon for the "Export Logins..." menu item should be toolbarButton-upload.svg and not toolbarButton-download.svg or better said, the arrow in that icon should point "up" and now "down", because "Export Logins..." means uploading a password file to a computer. So, uploading usually has an icon with an arrow pointing up, while downloading usually has an icon with an arrow pointing down.

So my solution is:

  • toolbarButton-download.svg icon for the "Import from a File..." menu item,
  • toolbarButton-upload.svg icon for the "Export Logins..." menu item.

from firefox-ui-fix.

black7375 avatar black7375 commented on May 24, 2024

"Export Logins..." icon thinks Mozilla's decision is okay because the information from the browser is downloaded to the computer.
So I've only replaced the icon.


I don't think "Import from Another Browser..." and "Import from File..." are menus that appear at the same time, so shouldn't they have the same icon?

from firefox-ui-fix.

Aleksandra0056 avatar Aleksandra0056 commented on May 24, 2024

"Export Logins..." icon thinks Mozilla's decision is okay because the information from the browser is downloaded to the computer. So I've only replaced the icon.

Okay, now I realized, that you did the fix right.

I don't think "Import from Another Browser..." and "Import from File..." are menus that appear at the same time, so shouldn't they have the same icon?

What do you mean with this sentence?

from firefox-ui-fix.

black7375 avatar black7375 commented on May 24, 2024

Secondly, I think I explained it wrong.
"Import from Another Browser..." and "Import from File..." seem to appear in different contexts.
(My prediction is that the two icons will not appear together.)

So I don't think it matters if the icon shape is duplicated.


If two icons can appear in the same situation, it's confusing and should be changed.

from firefox-ui-fix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.