Comments (4)
I want to note, that the #862 was incorrectly fixed, but I will write it here instead of creating a new issue.
The new Proton icon for the "Export Logins..." menu item should be toolbarButton-upload.svg
and not toolbarButton-download.svg
or better said, the arrow in that icon should point "up" and now "down", because "Export Logins..." means uploading a password file to a computer. So, uploading usually has an icon with an arrow pointing up, while downloading usually has an icon with an arrow pointing down.
So my solution is:
toolbarButton-download.svg
icon for the "Import from a File..." menu item,toolbarButton-upload.svg
icon for the "Export Logins..." menu item.
from firefox-ui-fix.
"Export Logins..." icon thinks Mozilla's decision is okay because the information from the browser is downloaded to the computer.
So I've only replaced the icon.
I don't think "Import from Another Browser..." and "Import from File..." are menus that appear at the same time, so shouldn't they have the same icon?
from firefox-ui-fix.
"Export Logins..." icon thinks Mozilla's decision is okay because the information from the browser is downloaded to the computer. So I've only replaced the icon.
Okay, now I realized, that you did the fix right.
I don't think "Import from Another Browser..." and "Import from File..." are menus that appear at the same time, so shouldn't they have the same icon?
What do you mean with this sentence?
from firefox-ui-fix.
Secondly, I think I explained it wrong.
"Import from Another Browser..." and "Import from File..." seem to appear in different contexts.
(My prediction is that the two icons will not appear together.)
So I don't think it matters if the icon shape is duplicated.
If two icons can appear in the same situation, it's confusing and should be changed.
from firefox-ui-fix.
Related Issues (20)
- The "Export Logins..." item uses an incorrect & old Photon-like thick icon HOT 1
- Address bar dropdown is transparent on 122, making reading text difficult HOT 15
- active tab has transparent background HOT 2
- Automatically hide toolbar. Overlay vs displace page
- Theme tab/menu bar background not applied correctly HOT 4
- Theme can't apply HOT 14
- Add an option to restore the green background on the "Update available – download now" HOT 1
- Theme can't apply HOT 1
- Site jumps with hidden tabs after 41acca6f96dc7fa98ca09097421819b4448ca893 commit HOT 6
- Icon for "Tabs Sharing Devices" drop down on Linux (Gnome) HOT 1
- Missing icons on menu bar context menu (Copy Without Site Tracking, Paste and Go) HOT 3
- Can't scroll tab bar when tab preview is open HOT 2
- Version comment user.js HOT 2
- Windows 11 Default Theme NOT Applying HOT 4
- Bookmar menu icons overlap text HOT 5
- Remove chrome-only `:-moz-lwtheme` pseudo-class HOT 1
- Breaks on FF 126b1 HOT 14
- Tabs' clickable area does not reach the top of the screen on Firefox 125 and KDE Plasma HOT 2
- browser.tabs.cardPreview.enabled revert back after closing the browser HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firefox-ui-fix.