MySQL and Elasticsearch Templates Conflict about charts HOT 4 CLOSED

Hi,

This is an issue if you're using the charts as subcharts since elasticsearch's template expects 3 arguments to printf while mysql only expects 2.

As you can check on the line below:

https://github.com/bitnami/charts/blob/master/bitnami/elasticsearch/templates/_helpers.tpl#L40

It's using .Values.master.name which exists on ES' values.yaml but it doesn't exist on MySQL's values.yaml.

The problem is not about the number of arguments used on each macro but using the same name for both macros. We're defining twice the macro "master.fullname"...

@tompizmor @javsalgar how should we solve this? Should we sth like "mysql.master.fullname" and "es.master.fullname"

The templates should have namespaces (such as the PostgreSQL templates).

I don't really understand what you mean with that.

from charts.

Hi Juan,

To clarify, the Elasticsearch helper template "master.fullname" passes three arguments to printf and the MySQL helper template "master.fullname" passes two. When I tried to do a deployment with them, it failed since the configuration ended up with the following (since the Elasticsearch chart's templates take precedence):

metadata:
  name: testing-mysql-%!s(<nil>)

What I mean by namespacing is exactly what you suggest, "master.fullname" should likely be "mysql.master.fullname" and "es.master.fullname" (which is what the PostgreSQL chart does as it has a "postgresql.master.fullname" helper template).

In the interim, I've added a master.name to my chart's values.yaml that fixes the issue. But this should likely be fixed at the source.

from charts.

Hi @rmckayfleming

Sorry for the confusion with what "namespace" means... Yes, I see your point and I'm opening some PRs to implement that solution. Thanks so much for opening the issue. You can find the PRs in the links below:

• #816
• #817

from charts.

We just update the charts including the changes you suggested! Please feel free to use the new charts and reopen the issue if you continue facing issues with the macros.

from charts.