Code Monkey home page Code Monkey logo

Comments (8)

github-actions avatar github-actions commented on June 20, 2024

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from charts.

CeliaGMqrz avatar CeliaGMqrz commented on June 20, 2024

Hi @DorBreger

Thanks for your feature request!

We are glad to hear that you are willing to open a PR to make this change. It sounds like a great improvement to enable watchdog and I appreciate your efforts to make this happen. The Bitnami team will be happy to review it and provide feedback. Here you can find the contributing guidelines.

from charts.

DorBreger avatar DorBreger commented on June 20, 2024

I have experimented a bit and I was wondering if such a feature would be necessary? It seems the pgpools don't promote a new primary themselves, rather they only look for a new one in case of a failed primary. Watchdog would mean that only one pgpool is active at a time, meaning if that pod becomes inactive for any reason (even a node drain being ran) the database is inaccessible until failover happens at the pgpool/watchdog level. On the other hand, watchdog will help in some corner cases of network partition. Waiting to hear your feedback.

from charts.

github-actions avatar github-actions commented on June 20, 2024

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from charts.

CeliaGMqrz avatar CeliaGMqrz commented on June 20, 2024

Hi @DorBreger,

Sorry for the delay.

Thanks for your feedback and your initiative to contribute to this feature. To better understand the impact and necessity of this improvement, we need more information about the split-brains scenarios you mentioned, especially in the context of a single pg pool.

We acknowledge that this feature would be beneficial to improve high availability. However, if implemented, it should be made optional. Also, we think it's important to include a clear warning about the drawbacks you mentioned, specifically regarding the database becoming unreachable.

We would greatly appreciate it if you could provide us with more details on this matter.

from charts.

DorBreger avatar DorBreger commented on June 20, 2024

Hi @CeliaGMqrz , thank you for responding.
In certain possible configurations, a pgpool initiates a failover when it finds the primary node backend unavailable. When using watchdog, the pgpools vote on whether the primary node is actually available.
However, it seems like in our configuration it is repmgr that initiates failovers and when a failover is detected the pgpool simply looks for a new primary. Therefore if we will be using Watchdog we would either need to have it initiate failovers instead of repmgr in order to benefit from it. Otherwise, the current possible configuration of multiple pgpools that aren't clustered works well enough, and it has the advantage that if a pod goes down for any reason, even a planned worker outage, the database stays available, unlike in a watchdog configuration in which the primary pgpool is the only one that can serve the application database services.

from charts.

DorBreger avatar DorBreger commented on June 20, 2024

I think that the other issue I opened, in regards to a pgpool exporter is more beneficial to improving the availability of the services this helm chart provides. it is rather easy to implement and I'm willing to do so, I only need some guidance from youm

from charts.

CeliaGMqrz avatar CeliaGMqrz commented on June 20, 2024

Hi @DorBreger

After considering the incompatibilities and discussing them with the team, we have decided to focus on the other open request. Thanks for your feedback.

from charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.