Run-time error occurs when telegram configurations are not set. about node-binance-trader HOT 8 CLOSED

The reason the error is occurs even though the constant use_telegram is set to default is that the TeleBot object is being instantiated without check if it will be needed in trader.js:

const telBot = new TeleBot({
    token: telegramToken, // Required. Telegram Bot API token.
    polling: { // Optional. Use polling.
     ...

And inside the telebot.js, the constructor has the following check:

        if (!cfg.token || cfg.token.split(':').length !== 2) {
            throw Error('[bot.error] invalid bot token');
        }

The cfg.token default value fails because the default cfg_token value is not in the expected format.

Possible Solutions are:

• Dirty Solution
  To add one single double point : character in the default value of cfg.token in telebot.js.
• A Better Solution
  To move config constant preferences such as use_telegram and other on the top of trader.js and for the telegram bot case, to add checks if the value is true. This way is not only cleaner but provides a better performance as it does not call constructors which will then not be used through the lifetime of the application.

I would personally go for the better solution. I will issue a pull request shortly.

from node-binance-trader.

I reverted the last commit from the PR that caused the issue for now. Please feel free to try again.

from node-binance-trader.

@Plasto13 could you please take a look at this issue?

from node-binance-trader.

Hello @jsappme I contacted @Plasto13 in the Discord Channel stated in the README.md file about this issue. I also forked the repository and will introduce a pull request to fix the issue shortly.

from node-binance-trader.

Perfect. Thank you. @insertmike

from node-binance-trader.

Hello @jsappme the content I added has been successfully added, thanks for approving the request. However some part of the merging has not been successful, for example missing dependencies because of the revert of commit id 094e2f2f480fe180a33ed1e4117da2156dcc45e6. I am fixing it shortly and will create another pull request. Sorry!

from node-binance-trader.

from node-binance-trader.

Great! Now it is all up and running. I am closing this issue as its solution is commited in pull request #41 and #42.

from node-binance-trader.