Code Monkey home page Code Monkey logo

Comments (9)

dargmuesli avatar dargmuesli commented on June 12, 2024

made a pull request #80 for an automatic update of the margin pairs, but this doesn't solve the problem

What problem does the PR solve then?

from node-binance-trader.

5queezer avatar 5queezer commented on June 12, 2024

from node-binance-trader.

dargmuesli avatar dargmuesli commented on June 12, 2024

Ok, gotcha. So why do margin trades still fail? You mention bnb_client.mgBorrow. Is it because the margin tradable pairs could be outdated again by when the trade is executed or what do you see there?

from node-binance-trader.

5queezer avatar 5queezer commented on June 12, 2024

from node-binance-trader.

dargmuesli avatar dargmuesli commented on June 12, 2024

Please excuse my confusion, but what's the difference between available margin pairs and coins available for cross margin trading?
When we fetch the pairs, no matter what they're quoted against, that are available for margin trading, under which circumstances will there be an error?

from node-binance-trader.

5queezer avatar 5queezer commented on June 12, 2024

Please excuse my confusion, but what's the difference between available margin pairs and coins available for cross margin trading?

The script uses cross margin trading only. There's no difference between those two. There's also isolated margin, which is not used in our script.

When we fetch the pairs, no matter what they're quoted against, that are available for margin trading, under which circumstances will there be an error?

The error occurs when the signal from BVA contains a coin that is not available for cross margin trading.

For example, go to https://www.binance.com/en/my/wallet/account/margin and type into the search coin field ENJ, which you won’t find. Then go to isolated margin https://www.binance.com/en/my/wallet/account/margin/isolated and type ENJ again, and there you can find the coin.

from node-binance-trader.

dargmuesli avatar dargmuesli commented on June 12, 2024

For example, go to https://www.binance.com/en/my/wallet/account/margin and type into the search coin field ENJ, which you won’t find. Then go to isolated margin https://www.binance.com/en/my/wallet/account/margin/isolated and type ENJ again, and there you can find the coin.

Ok, understood so far. But https://www.binance.com/gateway-api/v1/friendly/margin/symbols only returns margin symbols so if a symbol isn't included there, the script should already fall back to normal trading. But it doesn't for you and that's the error you experience?

from node-binance-trader.

5queezer avatar 5queezer commented on June 12, 2024

Obviously, the error affects short trades only that aren't in the margin pair list. Therefore a fallback to normal trading isn't possible. Possible workarounds: using futures or isolated margin.

from node-binance-trader.

dargmuesli avatar dargmuesli commented on June 12, 2024

Ohh, we're talking about selling 😄
Well, I think we can exclude unsellable pairs from execution. I doubt that using isolated margin is a good choice for now, because you'd need to have funds there for every possibly tradable pair, don't we? At least for now. I currently don't have experience with future trading, so I can't say if that's currently a desired workaround. @jsappme that'd be your decision.

from node-binance-trader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.