Comments (2)
The additional issues is that the link is hardcoded in the LANG.yml files for all languages. We have localhost
showing in some Spanish and German pages, but for the other languages we have the value that was originally in the en.yml
, so basically a link to the English section of the website.
https://github.com/bisq-network/bisq-website/blob/master/_data/ja.yml#L56
IMO there are 2 ways to fix this:
- Harcode the link to the related language in LANG.yml. So in the example above, the link could be
<a href="https://bisq.network/ja/community/">
- Split the sentences in more variables, leaving the link out and adding it to the layout. This way every language would pick the correct link for them.
The last option is time consuming and requires small changes to the base layout and to add some variables, but resolves the problem in the long term. The first option is quicker to implement and doesn't require any important change, but will require more attention from future translators (since they will copy and paste that section, they have to be reminded that they need to adapt the link adding the code for thir language).
I think the first option could be good enough in our case.
from bisq-website.
Fixed with #266.
from bisq-website.
Related Issues (20)
- Improve and document translation workflow HOT 2
- Remove country icons from language selector HOT 4
- Remove negative left margin from headers in homepage HOT 1
- Download page (https://bisq.network/downloads/) has a bad link to "PGP Signatures." HOT 1
- Add openSUSE to the rpm package download label HOT 1
- The markets page is publishing duplicates of trades HOT 5
- List Matrix channel on Community page HOT 6
- Bisq.network On-Site Search Engine Optimization HOT 1
- Experiment on changing the Bisq landing page HOT 1
- Create friendly, interactive, simple getting-started page HOT 2
- Add search to website HOT 8
- Revisions to Getting Started page visual styles HOT 1
- Trade History should display whether trade was a sell or buy HOT 1
- wip: Accessibility issues HOT 6
- Add License HOT 3
- Daemon & CLI info on downloads page
- Dashboard elements need to be updated.
- Add Bisq 2 section to webpage and add download links
- Roadmap links to outdated GH page
- Fix color mismatch
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bisq-website.