Code Monkey home page Code Monkey logo

Comments (2)

erciccione avatar erciccione commented on August 22, 2024

The additional issues is that the link is hardcoded in the LANG.yml files for all languages. We have localhost showing in some Spanish and German pages, but for the other languages we have the value that was originally in the en.yml, so basically a link to the English section of the website.
https://github.com/bisq-network/bisq-website/blob/master/_data/ja.yml#L56

IMO there are 2 ways to fix this:

  • Harcode the link to the related language in LANG.yml. So in the example above, the link could be <a href="https://bisq.network/ja/community/">
  • Split the sentences in more variables, leaving the link out and adding it to the layout. This way every language would pick the correct link for them.

The last option is time consuming and requires small changes to the base layout and to add some variables, but resolves the problem in the long term. The first option is quicker to implement and doesn't require any important change, but will require more attention from future translators (since they will copy and paste that section, they have to be reminded that they need to adapt the link adding the code for thir language).

I think the first option could be good enough in our case.

from bisq-website.

m52go avatar m52go commented on August 22, 2024

Fixed with #266.

from bisq-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.