biril / mp3-parser Goto Github PK

Remove dependency on ArrayBuffer.slice

mp3-parser\lib\lib.js:223 Uncaught RangeError: Invalid typed array length

return String.fromCharCode.apply(null, new Uint16Array(buffer, offset, length / 2));
^
RangeError: Invalid typed array length
at new Uint16Array (native)
at Object.lib.readStr.ucs (node_modules\mp3-parser\lib\lib.js:223:52)
at readFrameContentIpls (node_modules\mp3-parser\lib\id3v2.js:331:53)
at Object.mp3Id3v2Parser.readId3v2TagFrame (node_modules\mp3-parser\lib\id3v2.js:559:28)
at Object.mp3Id3v2Parser.readId3v2Tag (node_modules\mp3-parser\lib\id3v2.js:638:36)
at Object.mp3Parser.readId3v2Tag (node_modules\mp3-parser\main.js:113:28)

Hi, with this package, I can make a streaming of mp3 file with socket.io??...

Something like this using your example file

var fs = require("fs"),
    io = require('socket.io')(),
    util = require("util"),
    mp3Parser = require("mp3-parser"),
    toArrayBuffer = function (buffer) {
        var bufferLength = buffer.length, i = 0,
            uint8Array = new Uint8Array(new ArrayBuffer(bufferLength));

        for (; i < bufferLength; ++i) { uint8Array[i] = buffer[i]; }
        return uint8Array.buffer;
    };

io.on('connection',function(socket){
socket.on('audio',function(data){
fs.readFile(data.pathToMp3, function (error, buffer) {
    if (error) {
        console.log("Oops: " + error);
        process.exit(1);
    }
    buffer = new DataView(toArrayBuffer(buffer));

    var lastFrame = mp3Parser.readLastFrame(buffer),
        tags = mp3Parser.readTags(buffer);


//how i send the chuck to the server? socket.send('chunk',tags)??

});
});
});

I'm trying to use this in an ember-cli project via the global method. I couldn't get mp3-parser to load until I realized that the lib/lib.js module was undefined in all the consuming modules. It looks like the culprit are these lines:

https://github.com/biril/mp3-parser/blob/master/lib/id3v2.js#L34
https://github.com/biril/mp3-parser/blob/master/lib/xing.js#L34
https://github.com/biril/mp3-parser/blob/master/main.js#L34

Once I changed these to reference globalObject. mp3Parserlib it worked. That name is defined here:
https://github.com/biril/mp3-parser/blob/master/lib/lib.js#L26