biowpn / gobattlesim-python Goto Github PK

Right now we can only get some overall metrics once a simulation is done, such as duration, winner, number of deaths. It would be preferred to get individual Player/Pokemon's battle outcomes:

...
my_battle.add_player(my_player)
my_battle.init()
my_battle.start()
...
my_player_outcome = my_battle.get_player_outcome(my_player)

In demo.py, a custom strategy - use fast attacks only - has been defined, which doesn't utilize the strategy_input passed to the on_free callback. In general, we want to get some useful info regarding the subject Pokemon and/or its enemy at the time making a decision. However, the strategy_input, supposed to provide such info, is next to useless due to lacking proper accessing methods.

The user should be provided with ways to acquire info, including but not limited to:

• The state of the subject Pokemon/enemy Pokemon, including current HP, energy
• The moves of the Pokemon/enemy Pokemon, including power, energy, duration, etc
• Damage calculating method to get the damage values

There are only three built-in strategies right now:

1. defender
2. attacker_no_dodge
3. attacker_dodge_all

Need at least one more essential strategy: attacker_dodge_special.

The battle participants are set by a series of add_X methods and the deep copy is performed.

Now, if the user wants to modify just one of the participant, such as changing the level of one Pokemon, he has no choice but to reconstruct the whole battle instance again. This is not desirable.

Some update_X methods are needed. That is, say there's a previous line of code

my_battle.add_player(my_player)

Then we change my_player by a little, such as changing the strategy:

my_player.set_strategy(2)

To reflect the change, if we could just write

my_battle.update_player(my_player)

That would be much preferred.

A possible way is to id-ing all Players and Pokemon, but this id is hidden from the user. It could be the count of instances.
Also, unlike add_X methods, update_X should be member functions of class Battle.

The set_parameter(name, value) method provided in gobattlesim.engine is supposed to set a specific battle parameter. But how do we know which name is associated with which parameter? A list of available battle parameters in documentation (which, by the way, is also missing) is eagerly needed.

A battle log is not available. It would be helpful to see what's going on in a battle.

It is sometimes desired to "clone" an attacker when simulating duo, trio or quartet battles since it greatly reduces run time. By cloning, simply multiply the attacker's damage values (post-rounding) by an integer.