APIL:

type TrashedFileInfo interface {
    AbsPath() string
    DeletionDate() time.Time
}

// Lookup checks whether there is any file with a matching path. The path can
// be relative or absolute. Since a path can be deleted multiple times,
// resulting in multiple trashed versions, the return value is an array. If
// the error is empty, there were no matches, in which case the `error` will
// be `nil`.
func Lookup(path string) ([]*TrashedFileInfo, error) {
    // ....
}

The interface TrashedFileInfo allows to have more concrete implementations, allowing the user to extract more information where required and possible, but still allow us to cross compile when using the bare minimum.

This will be a simple commandline tool that can execute each public function, such was wastebasket.Trash or wastebasket.Empty.

Currently the linux unit tests are only tested against trash-cli as gio and gvfs-trash aren't available on Travis CI and i can't figure out why Cirlce CI can't find any commands on PATH.

I currently don't have access to any Mac OS machine, therefore no optimisations have been done here yet. We invoke finder N times, which is possibly rather slow.

Interesting for this purpose:

• https://developer.apple.com/documentation/foundation/nsfilemanager/1414306-trashitematurl
• https://github.com/progrium/macdriver

While Mac Driver doesn't implement this functionality, we might be able to contribute this.
However, additionally, we could potentially just rip out what we need.

On top of that, this will introduce Cgo, which we want to keep optional where we can.
Therefore, the bad tell "Finder" solution will probably persist.

Currently, you'll have to call Trash multiple times, potentially causing a lot of overhead.
The function signature could simply be changed to Trash(path... string), which would still be backwards compatible. The errors would potentially changed, as there can be more than one.

Whether each tool invoked supports multifile, still needs to be figured out.

Hi, can you please remove the fmt.Println(psCommand) line in the wastebasket_windows.go file?
I am using your repo for a command line app which needs StdOut and StdErr to be clean, and that println statement pollutes it.
Thanks!

Sadly Windows PowerShell doesn't have any headless executable, therefore it always opens a commandline window, unless started from the commandline anyway.

The solution would be use the win32 API instead.

See:

• Trash
  • https://docs.microsoft.com/en-gb/windows/desktop/api/shobjidl_core/nf-shobjidl_core-ifileoperation-deleteitem
  • https://docs.microsoft.com/en-gb/windows/desktop/api/shobjidl_core/nf-shobjidl_core-ifileoperation-performoperations
• Empty
  • https://docs.microsoft.com/en-us/windows/desktop/api/shellapi/nf-shellapi-shemptyrecyclebinw
  • https://docs.microsoft.com/en-us/windows/desktop/api/shellapi/nf-shellapi-shemptyrecyclebina

Currently all we check is whether the file is gone, but part of successful trashing is also the possibility of a successful restoration.

This depends on #14

This is labeled as a bug, as we have to make sure the code is correct.

Currently we do not verify that calling Empty() actually empties the trashbin(s).

In order to do so, we need to implement either #8 or #13 first, even though #13 is preferred.

This is considered a bug, as it prevents secure usage of the library.

There are currently warnings about using outdated actions.

Support listing all trashed files from all trash bins that are readable.

API:

func List() ([]*TrashedFileInfo, error) {
    // ....
}

Depends on #13

After left over basic features have been added, we will comnpletly revamp the API.

Depends on:

• #13
• #8
• #14
• #16

Details to be decided on

Implement function to restore a file:

API:

// Restore will move the given file out of the trashbin back to its location
// before it was trashed. The path can be relative or absolute. If there is no
// matching file in any of the trashbins, an error is returned.
func Restore(path string) error {
    // ....
}

This would eliminate any dependency on packages such as gio or trash-cli and would eliminate the need for starting a process or parsing commandline output. Additionally, we still won't need CGO, which is a win.