bincode-org / bincode-core Goto Github PK

Leaving this here as a reminder for myself

Implement CoreRead and CoreWrite on any type implementing these traits:

https://docs.rs/embedded-hal/0.2.4/embedded_hal/spi/trait.FullDuplex.html

https://docs.rs/embedded-hal/0.2.4/embedded_hal/serial/trait.Write.html
https://docs.rs/embedded-hal/0.2.4/embedded_hal/serial/trait.Read.html

During the test write I have discovered that the VarInt is not used for primitives even if configured.

The index is being cast from a usize to u64 currently. I think it would be better to just return the usize so it can be used directly for indexing/slicing.

• Implement serialize_size
• Implement deserialize_enum or document why it should error
• Get rid of .expect
  • Serializer::serialize_seq with no length
  • Serializer::serialize_map with no length
• Test with alloc feature
• Refactor code so the codebase is clean
• Add missing docs
• Review all docs

Some panics in the code:

• Whenever serde throws a custom error (impl serde::de::Error for DeserializeError and impl serde::ser::Error for SerializeError)
• Deserializer::deserialize_any
• Deserializer::deserialize_identifier
• Deserializer::deserialize_ignored_any
• Serializer::collect_str (this accepts T: core::fmt::Display, we could make our own formatter and pass this to display)

I'm trying to publish a crate dependent on this bincode-core.

The current api works well for my purposes (both x86_64 and arm-none-eabi).

I am looking for no_std std::io alternative.

rust-lang/rust#77781