billti / lnk2005 Goto Github PK

Using dllimport/dllexport requires that the function always be tagged as one of the two. The #else case in mydll.h allows for V8_DLL to be defined to neither, and that is the cause of the link errors. Fixing that lets the build succeed. Here are the diffs I used:

diff --git a/mydll.h b/mydll.h
index 9130bab..0b56ab9 100644
--- a/mydll.h
+++ b/mydll.h
@@ -3,7 +3,7 @@
#elif defined(BUILDING_DLL)
#define V8_DLL __declspec(dllexport)
#else
-#define V8_DLL
+#error^M
#endif

class V8_DLL C {
diff --git a/obj1.cpp b/obj1.cpp
index 69d34e6..69e9eb3 100644
--- a/obj1.cpp
+++ b/obj1.cpp
@@ -1,3 +1,4 @@
+#define USING_DLL^M
#include "mydll.h"

int Obj1Func() {