billpugh / marmoset Goto Github PK

1. Create a prototype review with your own code as the prototype target.
2. Create some rubrics for the review.
3. Try to do review; no rubrics will be listed.

The problem is line 129 in CodeReviewSummary. That only adds rubrics to the 
list of unevaled rubrics if the user is not the author.

Neil tried to add a checkbox without specifying min/max values, and got an 
error when submitting a form.

When you download a project baseline or a submission, it should include a 
.submit and a .submitUser file

When an instructor downloads a baseline submission file, it shouldn't include a 
.submitUser file

Project was started before JUL existed. Update everything to use j.u.l.

Right now you can drop a rubric on a grayed-out line of code. Only modified 
lines of code should accept rubrics.

Jeff had a problem where when updating a new test setup, it often didn't find 
the old test set up.

It would be nice if when viewing the test results for a submission, you were 
able to view and edit the general comments for the submission.

What steps will reproduce the problem?
1. ant war reports deprecation and unchecked warnings
2. Add to build.xml the following after each <javac ....> tag
    <compilerarg value="-Xlint:deprecation"/>
    <compilerarg value="-Xlint:unchecked"/>
3. ant build reports that there are some 62 warnings to be addressed.

What is the expected output? What do you see instead?
  I believe I'm expecting a clean compile.  This may not be possible though you never know.

What version of the product are you using? On what operating system?
  Latest git repo downloaded on 1/6/2014, RHEL6 64 bit, Tomcat6, Java 1.7.0_45-b18


Please provide any additional information below.

What steps will reproduce the problem?
1. local.web.properties file contains:
database.driver=com.mysql.jdbc.Driver
database.server.jdbc.url=jdbc:mysql://localhost:3306/submitserver
2. the mysql jar file, mysql-connector-java-5.1.24-bin.jar, is in:
tomcat6/webapps/submitServer/WEB-INF/lib and
tomcat6/lib
3. As I understand tomcat, these are the default locations from which jar files 
are 
   expanded for the applications.
Log file shows the following:
Jan 07, 2014 3:49:09 PM org.apache.catalina.core.StandardContext filterStart
SEVERE: Exception starting filter ServletExceptionFilter
java.lang.RuntimeException: Unable to load sql driver com.mysql.jdbc.Driver
        at edu.umd.cs.submitServer.AbtractDatabaseProperties.<init>(AbtractDatabaseProperties.java:36)
        at edu.umd.cs.submitServer.SubmitServerDatabaseProperties.<init>(SubmitServerDatabaseProperties.java:41)
        at edu.umd.cs.submitServer.filters.SubmitServerFilter.init(SubmitServerFilter.java:131)
        at org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:295)
        at org.apache.catalina.core.ApplicationFilterConfig.setFilterDef(ApplicationFilterConfig.java:422)
        at org.apache.catalina.core.ApplicationFilterConfig.<init>(ApplicationFilterConfig.java:115)
        at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:3838)
        at org.apache.catalina.core.StandardContext.start(StandardContext.java:4488)
        at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:791)
        at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:771)
        at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:526)
        at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:905)
        at org.apache.catalina.startup.HostConfig.deployWARs(HostConfig.java:740)
        at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:500)
        at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1277)
        at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:321)
        at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119)
        at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1053)
        at org.apache.catalina.core.StandardHost.start(StandardHost.java:722)
        at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1045)
        at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:443)
        at org.apache.catalina.core.StandardService.start(StandardService.java:516)
        at org.apache.catalina.core.StandardServer.start(StandardServer.java:710)
        at org.apache.catalina.startup.Catalina.start(Catalina.java:593)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:289)
        at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414)



What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
latest marmoset as of 1/6/2014, rhel6, 64 bit, tomcat6


Please provide any additional information below.

Allow a project to provide a list of required files. If the files aren't 
provided, explain which files are missing, rather than more complicated error 
messages.

What steps will reproduce the problem?

1. Open the documentation for building a submit server 
(https://code.google.com/p/marmoset/wiki/SubmitServerSetup).

2. Get to the section "local.web.properties"

3. The following is incomplete, as there are no pages or links with details for 
OpenID or LDAP authentication: "You'll need to choose an authentication 
mechanism. The default is OpenID, but you can also choose LDAP as well. See 
their respective pages for details."

What is the expected output? What do you see instead?
--N/A--

What version of the product are you using? On what operating system?
--N/A--

Please provide any additional information below.
--N/A--

Even if authentication is set to LDAP, a user can navigate to 
/authenticate/openid/ and attempt to authenticate through OpenID. It's not 
clear what the consequences are, exactly, but it shouldn't be allowed.

Need to look through generated tags and make UMD-specific information reference 
new properties file.

If a build server dies while attending to build a submission, then when the 
build server restarts, report that information to the submit server

I have a server set up at http://cicada.cs.umd.edu:8080/

I had previously connected to it with my [email protected] open id. Now, I'm 
trying to connect again, and it tells me that I have a uid of 
e2aab3126a841fc3fb2ab3f69996cee5f9892fb4, which wasn't been registered. But the 
database already has me registered with a uid of 
6da3210b85d616e0ea37d5941548dd10b79c7ab7. 

How do we know that these uid's are guaranteed to be invariant? How is it 
computed? 

Support peer reviews in which students are assigned to review code from other 
students in the same section

What steps will reproduce the problem?
1. Try to setup marmoset submit server according to the Wiki-documentation on a 
plain Ubuntu/12.04, with installed Tomcat 7 and OpenJDK 1.7
2. Building of SubmitServer.war works
3. Deployment of SubmitServer.war fails

What is the expected output? What do you see instead?
Deployment of submitServer.war fails because of the following error message in 
Tomcat's log files:
-----
Jun 25, 2013 5:14:40 PM org.apache.catalina.core.StandardContext startInternal
SEVERE: Error filterStart
Jun 25, 2013 5:14:40 PM org.apache.catalina.core.StandardContext startInternal
SEVERE: Context [/submitServer] startup failed due to previous errors
Jun 25, 2013 5:14:40 PM org.apache.catalina.loader.WebappClassLoader 
clearReferencesThreads
SEVERE: The web application [/submitServer] appears to have started a thread 
named [com.google.inject.internal.util.$Finalizer] but has failed to stop it. 
This is very likely to create a memory leak.
Jun 25, 2013 5:14:40 PM org.apache.catalina.loader.WebappClassLoader 
checkThreadLocalMapForLeaks
SEVERE: The web application [/submitServer] created a ThreadLocal with key of 
type [com.google.inject.internal.InjectorImpl$1] (value 
[com.google.inject.internal.InjectorImpl$1@65cd7629]) and a value of type 
[java.lang.Object[]] (value [[Ljava.lang.Object;@1408b1f6]) but failed to 
remove it when the web application was stopped. Threads are going to be renewed 
over time to try and avoid a probable memory leak.
-----

So, what am I doing wrong?

Neil assigned a prototype review and the checkbox didn't show up in the code 
review

What steps will reproduce the problem?
1. No documentation on process
2. Using "Marmoset Help Pages" from 2005-2006 as a rough guide.
3. cd BuildServer; ant; wants DiffOutputStream in addition to 
SubmitServerModelClass as part of the build structure.
4. This process starts with building DiffOutputStream, but it is looking for a
   org.junit.test class that Diff.. does not contain.
5. There are two junit.jar files included, one in BuildServer/lib and one in
   SubmitServerModelClasses/lib.  However they are of different sizes, which
   I believe implies that they are different versions of junit?


What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

We should provide a webstart plugin for uploading source code.

It should ignore readonly files as specified by the baseline submission.

It should also ignore things specified in .submitIgnore

Submit server looks for properties grades.driver, grades.url, etc. on startup, 
fails if it can't find them. We need to decouple this before release.

Yahoo won't authenticate OpenID requests from hosts without a real hostname or 
those running on nonstandard ports. Once OpenID is implemented, we need to test 
it against yahoo to make sure it works in production.

The superuser page should list recent build failures.

What steps will reproduce the problem?
1. Downloaded latest marmoset: 3:00 PM/CST 1/6/2014
2. Generated war file: cd SubmitServer2; generated local.*.properties; ant war
3. Copy dist/submitServer to /usr/share/tomcat6/webapps
4. tomcat6 expanded war file.
5. Test: http://marmoset-demo.clear.rice.edu:8080/submitServer generates 404 
error
6. Logfiles show:
catalina.2014-01-06.log:SEVERE: Parse error in application web.xml file at 
jndi:/localhost/submitServer/WEB-INF/web.xml
catalina.2014-01-06.log:org.xml.sax.SAXParseException; systemId: 
jndi:/localhost/submitServer/WEB-INF/web.xml; lineNumber: 478; columnNumber: 
19; Error at (478, 19: Filter mapping specifies an unknown filter name 
SourceTextFilter
catalina.2014-01-06.log:SEVERE: Marking this application unavailable due to 
previous error(s)


What is the expected output? What do you see instead?
Web 404, resource unavailable


What version of the product are you using? On what operating system?
latest marmoset, tomcat6, RHEL6

Please provide any additional information below.

Got the following error report:

 [submit8 37] java.lang.ClassNotFoundException: com.cenqua.clover.CloverUtils
    at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
    at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
    at java.lang.Class.forName0(Native Method)
    at java.lang.Class.forName(Class.java:169)
    at edu.umd.cs.buildServer.builder.Clover.<clinit>(Clover.java:17)
    at edu.umd.cs.buildServer.ProjectSubmission.isPerformCodeCoverage(ProjectSubmission.java:282)
    at edu.umd.cs.buildServer.builder.JavaBuilder.compileProject(JavaBuilder.java:383)
    at edu.umd.cs.buildServer.builder.Builder.execute(Builder.java:207)
    at edu.umd.cs.buildServer.BuildServer.buildAndTestProject(BuildServer.java:863)
    at edu.umd.cs.buildServer.BuildServer.doOneRequest(BuildServer.java:512)
    at edu.umd.cs.buildServer.BuildServer.executeServerLoop(BuildServer.java:296)
    at edu.umd.cs.buildServer.BuildServerDaemon.main(BuildServerDaemon.java:635)

Branch name: findbugs-reviewer

Please take a look at the changes in findbugs-reviewer, I had to write a lot of 
code in the model classes and I want you to do an idiot check.

We should make sure the build server works if we don't have clover available.

What steps will reproduce the problem?
1. Set the student first or last name like "Matevž"
2. The non-latin characters are changed to "?".
3. My name becomes "Matev?"

What is the expected output? What do you see instead?
Matevž

What version of the product are you using? On what operating system?
http://marmoset-demo.cs.umd.edu:8080

Please provide any additional information below.

Right now, .submit depends on having the combination of course name, semester 
and section be unique.

Instead, should have a submit_key which is unique.

It's not clear what "Import Project" is supposed to do, and it throws unhelpful 
NPEs when used improperly.

when combining multiple courses from the submit server, provide distinct 
sections for different courses.

What steps will reproduce the problem?
1. build SubmitServer2 from git master
2. create database with supplied version of 
SubmitServerModelClasses/marmoset-schema.sql
3. enter some value for the "Initialize the submit server; provide your 
Directory ID" field in: 
http://server:8080/submitServer/authenticate/ldap/?target=%2FsubmitServer%2Fview
%2Findex.jsp

What is the expected output? What do you see instead?
I expected to be able to create a new user as described in:
https://code.google.com/p/marmoset/wiki/SubmitServerSetup#Creating_the_first_use
r

instead I got:
Oops!
com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Table 
'marmoset.submitexport' doesn't exist

This error has been logged. Reference error number 7 if reporting this error.

What version of the product are you using? On what operating system?
Marmoset git master, Ubuntu 12.04LTS, Tomcat 7, Java 7

Please provide any additional information below.
I was using the SubmitServerModelClasses/marmoset-schema.sql from git master.  
Perhaps it is outdated compared to what the source expects.

What steps will reproduce the problem?
1. Using tomcat6.0.24-62 fails to build submitServer. Missing 
SetCharacterEncodingFilter
2. SetCharacterEncodingFilter was added to tomcat-6.0.36 and tomcat-7.x.x

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.
Just a detail to add to the documentation.

Also, SubmitServer2/WebRoot/WEB-INF/README.txt can be removed. It no longer 
seems to apply since SubmitServer2/lnf does not exist.

It looks like when a submission is tested, it now becomes enabled for 
background retesting. And it looks like it is often the case that all build 
servers will offer to retest it. 

If it happens that the submission takes a long time to test, this could take 
all the build servers off line.

We should increase the number of pending build requests when we do a background 
retest, and only retest submissions that have no pending background tests.

The displayProperties should also look at submitIgnore.

Right now, the hovertext for the "project number" field when creating a new 
project says this: "should be very short; doesn't have to be a number, probably 
shouldn't have spaces". Additionally, in the DB it's a VARCHAR(30). We should 
look at where it's used and clarify or remove the input.

In BuildServerConfiguration#loadAllProperties, the call to setBuildServerRoot 
uses the value of getBuildServerRoot, which obviously doesn't change the value 
of the build server root.

Should this property be deprecated in favor of buildServerWorkingDir?