billerickson / ea-starter Goto Github PK

Hello Bill,

Let me start by thanking you for this starter theme. It has been a huge part of my learning curve towards WordPress theme development.

I recently came across a weird issue while working on an ongoing project. I couldn't report with a live URL for now, but I was able to reproduce the same behavior over at your personal website.

As an example, let's take this specific page: https://www.billerickson.net/favicon-dark-mode/

Simply right click any image within the content and open it in a new tab.

Remove the image's file extension from the address bar of the browser and hit enter.

Such as, from this:
https://www.billerickson.net/wp-content/uploads/2021/07/dark-mode.jpg

To this:
https://www.billerickson.net/wp-content/uploads/2021/07/dark-mode

This should (in my opinion) return a 404 error (it does get a 404 response from the server) and use the theme's inc/archive-none.php partial to display the default not found message.

However, to my surprise, it returns a page with a list of posts.

I am not entirely sure if it's an issue or intended behavior.

Hi Bill,

In inc/helper-functions.php, within the ea_icon() function at L145, you're using the file_get_contents() function to inline SVG in the HTML.

I recently came around an old ticket on WP where someone suggested to use PHP readfile() instead of file_get_contents(), " as it doesn't cause it to be copied to memory before being output".

I know it doesn't make any visible difference in the loading, but I still wanted to hear your thoughts?

Fatal error: Uncaught Error: Call to undefined function ea_author_box() in /wp-content/themes/EA-Starter-master/single.php:41 Stack trace: #0 /wp-includes/class-wp-hook.php(288): ea_single_after_entry('') #1 /wp-includes/class-wp-hook.php(312): WP_Hook->apply_filters('', Array) #2 /wp-includes/plugin.php(478): WP_Hook->do_action(Array) #3 /wp-content/themes/EA-Starter-master/inc/tha-theme-hooks.php(191): do_action('tha_content_whi...') #4 /wp-content/themes/EA-Starter-master/inc/loop.php(34): tha_content_while_after() #5 /wp-includes/class-wp-hook.php(288): ea_default_loop('') #6 /wp-includes/class-wp-hook.php(312): WP_Hook->apply_filters('', Array) #7 wp-includes/plugin.php(478): WP_Hook->do_action(Array) #8 /wp-content/themes/EA-Starter-master/single.php on line 41

After publishing a new post, The title of post is displaying on homepage.
Please solve this issue. Thank you..

Hi,

I have set up the template to compile with Laravel Mix and Tailwind CSS and am in the process of eventually integrating TailwindCss fully into the theme. Everything works well so far.

However, as I was getting warnings about using slash as division in scss files, I updated the corresponding lines with the suggested lines by the Sass compiler. Everything works as expected except in one case it doesn't.

It suggests that I update ( ( $grid-width - $gap * ( $columns - 1 ) ) / $columns ) / $grid-width * 100%; with math.div($grid-width - $gap * $columns - 1, $columns); but this doesn't generate the correct values.

The following works but it appears like a hack and I am not sure if this is to correct way to address the issue.

math.div(math.div(($grid-width - $gap * ($columns - 1)), $columns), $grid-width * 000.010) + 0%;

Thanks.

Thanks for sharing this. A very minor issue: There is a broken link in the Wiki https://github.com/billerickson/EA-Starter/wiki that your intention was to point it to: https://www.advancedcustomfields.com/

Thanks for #13, Bill.

One more reason I had to edit core theme files when making an EA-starter child was this code in header.php.

echo '<div class="title-area">';
$logo_tag = ( apply_filters( 'ea_h1_site_title', false ) || ( is_front_page() && is_home() ) ) ? 'h1' : 'p';
echo '<' . $logo_tag . ' class="site-title"><a href="' . esc_url( home_url() ) . '" rel="home">' . get_bloginfo( 'name' ) . '</a></' . $logo_tag . '>';
//echo '<p class="site-description">' . get_bloginfo( 'description' ) . '</p>';
echo '</div>';

The commenting out of the site description, to be specific. My site uses that description.

I'd love it if this was done as a filter (ala the ea_h1_site_title right above). That way, I wouldn't have to edit this file to un-comment that out. :)

I think that's the only other thing I had to edit to make the whole theme work with a child theme.

Thanks again!

When I switch from the theme TwentyTwenty to EA-Starter-Master I loose the menu "Custom Fields" from my ACF Pro - so I can not use ACF with the new build of EA-Starter (downloaded today: 2019-11-29.).
I could use ACF with an EA-Starter build that I downloaded on 2019-09-06.
Help appreciated,
Andrea

All the docblocks end in space, star, backslash like this */

In Atom, when you copy/paste code into a page that only has a docblock, it thinks the space means everything should be indented by one space. It's super annoying!

Is there anything we can do to fix this? Just remove the space, or does anyone know how to fix this in Atom?

There is one , to much on line 33 in the file inc/author-box.php
I think :)

Specifically on body_class, post_class, and nav_menu_css_class

Right now with Leites on Pagely we keep going over bandwidth limits, so I’ve been analyzing stuff. They have a fairly moderate to large primary navigation (lots of dropdowns etc). So, I filtered to remove all the BS classes on the nav items except "current-menu" type classes. Since nav is on every page of the site, doing that made the HTML page size go down 5+ kb globally. 5kb over an average of 8 million page views a month translates to ​_40 gigs_​ saved in bandwidth per month…. 😮 which is 20% of the monthly bandwidth allotment

Hi Bill and others...
I'm really enjoying the simplicity of using the EA-Starter for Genesis and I'm looking to add some JS tricks to the mix. I was able to get SASS tasks to build in VSCode but I'm running into problems adding a JS library to the src folder and then minifying it. I'm using gulp for now and CodeKit isn't an option. I'd like to use VSCode's tasks to do the build but I'm stuck.
Would you be willing to share your JS tasks for this project so I can compare/contrast mine? TIA!

Script: https://github.com/artberri/sidr/blob/master/dist/jquery.sidr.min.js
Styles and JS: https://gist.github.com/billerickson/7f011ee2e2e85b1b2dc5#file-global-js

I'll use the .nav-primary as the source for the mobile menu. Here's an example of what changes when using a theme location.

It would be nice if the .sidr-class- was removed so they both could use the same CSS.

For instance, change footer.php from this:

<?php
/**
 * EA Starter
 *
 * @package      EAStarter
 * @since        1.0.0
 * @copyright    Copyright (c) 2014, Contributors to EA Genesis Child project
 * @license      GPL-2.0+
 */

?>
    <?php ea_structural_wrap( 'site-inner', 'close' ); ?>
    </div>

    <?php tha_footer_before(); ?>   
    <footer class="site-footer" role="contentinfo">
        <?php ea_structural_wrap( 'footer' ); ?>
        <?php tha_footer_top(); ?>

        <?php tha_footer_bottom(); ?>
        <?php ea_structural_wrap( 'footer', 'close' ); ?>
    </footer>
    <?php tha_footer_after(); ?>
</div>

<?php tha_body_bottom(); ?>
<?php wp_footer(); ?>

</body>
</html>

To this:

<?php
/**
 * EA Starter
 *
 * @package      EAStarter
 * @since        1.0.0
 * @copyright    Copyright (c) 2014, Contributors to EA Genesis Child project
 * @license      GPL-2.0+
 */

    ea_structural_wrap( 'site-inner', 'close' );
    echo '</div>';

    tha_footer_before();
    echo '<footer class="site-footer" role="contentinfo">';
        ea_structural_wrap( 'footer' );
        tha_footer_top();

        tha_footer_bottom();
        ea_structural_wrap( 'footer', 'close' );
    echo '</footer>';
    tha_footer_after();

    echo '</div>';

    tha_body_bottom();
    wp_footer();

    echo '</body>';
    echo '</html>';

I'm loving using EA-starter on my project, but I was hoping to use it as a parent theme, that way I could keep up with any changes here. There are sufficient hooks for nearly everything that I needed to use to make my child work -- except for one minor spot.

My project uses a bunch of SVG icons, and I love the functionality of ea-icon (in helper-functions). But it's not child theme friendly. A one line change makes it work with child themes though.

Simply swapping in get_theme_file_path does the trick.

$icon_path = get_theme_file_path( '/assets/icons/' . $atts['group'] . '/' . $atts['icon'] . '.svg' );

I have a version with this change ready for a pull request if you'd like.

Thanks, and BTW, thank you very much for this theme, I love it.

Hi Bill,
thanks for share your starter theme.
I'm on it and begin a work for my own website.
I've got an error whith acf site options, no options are available in back-office and i have this error on my Query Monitor :
call_user_func_array() expects parameter 1 to be a valid callback, class 'BE_ACF_Customizations' does not have a method 'dynamic_layouts'

and some others warning from ACF Pro
Can you help me to fix them ?

Thanks in advance

See below my configuration :

`

wp-core

version: 5.3.2
site_language: fr_FR
user_language: fr_FR
timezone: +00:00
permalink: /%postname%/
https_status: false
user_registration: 0
default_comment_status: open
multisite: false
user_count: 1
dotorg_communication: true

wp-paths-sizes

wordpress_path: /app/public
wordpress_size: 40,22 MB (42175626 bytes)
uploads_path: /app/public/wp-content/uploads
uploads_size: 0,00 B (0 bytes)
themes_path: /app/public/wp-content/themes
themes_size: 1,77 MB (1854861 bytes)
plugins_path: /app/public/wp-content/plugins
plugins_size: 7,39 MB (7752575 bytes)
database_size: 2,09 MB (2195456 bytes)
total_size: 51,48 MB (53978518 bytes)

wp-dropins (1)

db.php: true

wp-active-theme

name: Your Website (EA-Starter-master)
version: 1.0.0
author: Bill Erickson
author_website: https://www.billerickson.net
parent_theme: none
theme_features: tha_hooks, editor-styles, editor-style, admin-bar, automatic-feed-links, body-open, title-tag, post-thumbnails, menus, html5, responsive-embeds, align-wide, disable-custom-font-sizes, editor-font-sizes, disable-custom-colors, editor-color-palette, widgets
theme_path: /app/public/wp-content/themes/EA-Starter-master

wp-themes-inactive (1)

Twenty Twenty: version: 1.1, author: L’équipe WordPress

wp-mu-plugins (1)

WP CLEAN RESET: version: 0.9.9, author: Jean michel Silone

wp-plugins-active (3)

Advanced Custom Fields PRO: version: 5.8.7, author: Elliot Condon
Query Monitor: version: 3.5.2, author: John Blackbourn
WP Template Viewer: version: 1.0.0, author: keesiemijer

wp-media

image_editor: WP_Image_Editor_Imagick
imagick_module_version: 1673
imagemagick_version: ImageMagick 6.8.9-9 Q16 x86_64 2018-05-18 http://www.imagemagick.org
imagick_limits:
imagick::RESOURCETYPE_AREA: 2 GB
imagick::RESOURCETYPE_DISK: -1
imagick::RESOURCETYPE_FILE: 786432
imagick::RESOURCETYPE_MAP: 2 GB
imagick::RESOURCETYPE_MEMORY: 996 MB
imagick::RESOURCETYPE_THREAD: 1
gd_version: bundled (2.1.0 compatible)
ghostscript_version: 9.06

wp-server

server_architecture: Linux 4.9.93-boot2docker x86_64
httpd_software: Apache/2.4.10 (Debian)
php_version: 7.3.2 64bit
php_sapi: fpm-fcgi
max_input_variables: 3000
time_limit: 900
memory_limit: 256M
max_input_time: -1
upload_max_size: 1000M
php_post_max_size: 1000M
curl_version: 7.38.0 OpenSSL/1.0.1t
suhosin: false
imagick_availability: true
htaccess_extra_rules: false

wp-database

extension: mysqli
server_version: 5.6.34
client_version: mysqlnd 5.0.12-dev - 20150407 - $Id: 7cc7cc96e675f6d72e5cf0f267f48e167c2abb23 $

wp-constants

WP_HOME: undefined
WP_SITEURL: undefined
WP_CONTENT_DIR: /app/public/wp-content
WP_PLUGIN_DIR: /app/public/wp-content/plugins
WP_MAX_MEMORY_LIMIT: 256M
WP_DEBUG: false
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: false
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_LOCAL_DEV: true
DB_CHARSET: utf8
DB_COLLATE: undefined

wp-filesystem

wordpress: writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable
mu-plugins: writable

`