bigpresh / business-tax-vat-validation Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 5.0 68 KB

Business::Tax::VAT::Validation - a Perl module to validate EU VAT numbers

License: GNU General Public License v3.0

Perl 99.40% Raku 0.60%

business-tax-vat-validation's People

Contributors

Stargazers

Watchers

Forkers

pvoglhofer davel fschlich tswfi pottenmak

business-tax-vat-validation's Issues

ServerMS_MAX_CONCURRENT_REQ

Invalid response, please contact the author of this module. env:ServerMS_MAX_CONCURRENT_REQ

Seems as they are throttling access to the service, somehow. Most probably you can't do anything about it, but providing a better error message, but just so you know.

Cheers and thanks for the module!

HTTP Connection to VIES not working anymore

Since today a call to the VIES URL http://ec.europa.eu/taxation_customs/vies/services/checkVatService results in an attempt to redirect from HTTP to HTTPS. Since this does not work on the API level, it results in an error code 257 with the following message:

Invalid response [302], please contact the author of this module. <HTML><HEAD> <TITLE>Redirect</TITLE> </HEAD> <BODY> <big></big> <blockquote> <TABLE border=0 cellPadding=1 width="80%"> <TR><TD> <big>Redirect (policy_request_redirect)</big> </TD></TR> <TR><TD> Click <a href="https://ec.europa.eu/taxation_customs/vies/services/checkVatService">here</a> if you are not automatically redirected. </TD></TR> <TR><TD> </TD></TR> <TR><TD> For assistance, contact your network support team. </TD></TR> </TABLE> </blockquote> </BODY></HTML>

To fix this the Base URL needs to be changed from HTTP to HTTPS.

UK VAT numbers can no longer be validated?

According to https://ec.europa.eu/taxation_customs/vies/

As of 01/01/2021, the VoW service to validate UK (GB) VAT numbers ceased to exist while a new service to validate VAT numbers of businesses operating under the Protocol on Ireland and Northern Ireland appeared. These VAT numbers are starting with the “XI” prefix, which may be found in the “Member State / Northern Ireland” drop down under the new entry “XI-Northern Ireland”. Moreover, any quote of “Member State” is replaced by “Member State / Northern Ireland” and any quote of “MS” is replaced by “MS / XI”. All traders seeking to validate UK (GB) VAT numbers may address their request to the UK Tax Administration.

Always check fault-code - VIES can return errors with a 200 OK status

It looks like VIES can return a timeout error with a HTTP 200 status.

Kindly reported by Friedrich Gehring at ePages:

thank you for maintaining the module for the VATID validation
Business::Tax::VAT::Validation. While using it with our software
epages, we encountered the following problem: We receive an error
code 257 from your module and the related error message from the VIES
database is as follows:

"Invalid response, please contact the author of this module
<soap:Envelope
xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">soap:Bodysoap:Faultsoap:ServerTIMEOUT</soap:Fault></soap:Body></soap:Envelope>"

Looks like, if we can't trust VIES to set a non-200 status on error, then we should always look for the faultcode/faultstring elements - should be a fairly simple fix.

License ambiguity

Its unclear if this is GPL, GPL-3, or GPL-1+

Vague:

Business-Tax-VAT-Validation/lib/Business/Tax/VAT/Validation.pm

Lines 19 to 22 in 5743ce6

    
           #                                                                            # 
        
           # THIS SOFTWARE IS RELEASED UNDER THE GNU Public Licence                     # 
        
           # Please see COPYING for details                                             # 
        
           #                                                                            #

GPL-1?:

Business-Tax-VAT-Validation/lib/Business/Tax/VAT/Validation.pm

Lines 471 to 474 in 5743ce6

    
           =head1 LICENSE 
        
           GPL. Enjoy! See COPYING for further information on the GPL.

GPL-3??:

Business-Tax-VAT-Validation/Makefile.PL

Lines 13 to 15 in 5743ce6

	AUTHOR => 'David Precious <[email protected]>',
	LICENSE => 'GPL_3',
	META_MERGE => {

Suggesting GPL-1:

Business-Tax-VAT-Validation/examples/vat.cgi

Lines 11 to 14 in 5743ce6

    
           #                                                                            # 
        
           # THIS SOFTWARE IS RELEASED UNDER THE GNU Public Licence                     # 
        
           # See COPYING for details                                                    # 
        
           #                                                                            #

Business-Tax-VAT-Validation/examples/vat_cli.pl

Lines 11 to 14 in 5743ce6

    
           #                                                                            # 
        
           # THIS SOFTWARE IS RELEASED UNDER THE GNU Public Licence                     # 
        
           # See COPYING for details                                                    # 
        
           #                                                                            #

Obviously, the COPYING file is GPL-3, and it looks like the overwhelming intent was to make it GPL-3 licensed. However, in some places the reference point is slightly ambiguous.

For instance, it's usually stated "Under the GNU Public License version 3", or in other cases "Under the GNU Public License version 3, or at your choice, any newer version", or something like that, to make it less necessary. As-is, I can't tell if the intent is "GPL-3" or "GPL-3+"

EU has changed their SOAP endpoint? "The given SOAPAction http://www.w3.org/2003/05/soap-envelope does not match an operation"

Got some reports from our customers that VATID checks were only doing local checks.

cloned the master branch and tested with the example cli script.

$ perl -I ../lib vat_cli.pl FI22486726
Error 257 : Invalid response, please contact the author of this module. <soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/"><soap:Body><soap:Fault><faultcode>soap:Server</faultcode><faultstring>The given SOAPAction http://www.w3.org/2003/05/soap-envelope does not match an operation.</faultstring></soap:Fault></soap:Body></soap:Envelope>

Tried to find some changelog type thing from EU site but could not find any.

But these two pages point to different wsdl files:
https://ec.europa.eu/taxation_customs/vies/technicalInformation.html
https://ec.europa.eu/taxation_customs/vies/faq.html#item_18

Use JSON::MaybeXS

Use JSON::MaybeXS instead of JSON

bigpresh / business-tax-vat-validation Goto Github PK

business-tax-vat-validation's People

Contributors

Stargazers

Watchers

Forkers

business-tax-vat-validation's Issues

ServerMS_MAX_CONCURRENT_REQ

HTTP Connection to VIES not working anymore

UK VAT numbers can no longer be validated?

Always check fault-code - VIES can return errors with a 200 OK status

License ambiguity

EU has changed their SOAP endpoint? "The given SOAPAction http://www.w3.org/2003/05/soap-envelope does not match an operation"

Use JSON::MaybeXS

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	# #
	# THIS SOFTWARE IS RELEASED UNDER THE GNU Public Licence #
	# Please see COPYING for details #
	# #

	=head1 LICENSE

	GPL. Enjoy! See COPYING for further information on the GPL.

	# #
	# THIS SOFTWARE IS RELEASED UNDER THE GNU Public Licence #
	# See COPYING for details #
	# #