Add back dbSnp ID field about bdg-formats HOT 4 CLOSED

So one solution is to make
https://github.com/bigdatagenomics/bdg-formats/blob/master/src/main/resources/avro/bdg.avdl#L961
union { null, int} dbsnp = null
instead, so it acts as both a flag and a value. Is that a good solution?
Though that might be untrue to the reserved VCF key...

from bdg-formats.

Perhaps it is better to have an ID field in VariantAnnotation which is a string, that could capture whatever was in the ID field (3rd column) of the VCF field, and for dbSNP we would keep the "rs" prefix as that defines and accessioning space.

Or - are we sure this should be in VariantAnnotation rather than a String field in Variant?

from bdg-formats.

Perhaps it is better to have an ID field in VariantAnnotation which is a string, that could capture whatever was in the ID field (3rd column) of the VCF field, and for dbSNP we would keep the "rs" prefix as that defines and accessioning space.

I would +1 that.

Or - are we sure this should be in VariantAnnotation rather than a String field in Variant?

I personally like it more in VariantAnnotation but I can grok why it is a good fit in Variant. I'd love to hear other people's thoughts.

from bdg-formats.

from bdg-formats.