bhavjitchauhan / essentials Goto Github PK

The highlightText function sets the global rectMode, stroke and textAlign outside push/pop.

Commit changes are difficult to identify due to the library being built and documented at every commit.

The library should only ever be built in a separate release branch.

Currently, the environment detected is incorrect because Essentials is tested by creating prototype builds on Khan Academy. This environment is similar to that of loading from a CDN except for a few differences; one being the this variable.

Khan Academy prototype buid

console.log(this typeof Processing);
// expected output: true

CDN

console.log(this typeof Window);
// expected output: true

printf attempts to call the replaceAll method on the argument provided to it. This unsurprisingly throws the error if the argument is not a string:

string.replaceAll is not a function

This is not how printf is designed to be used, however, it should be an easy fix in theory.

For times less than 1 millisecond, formatDuration does not return a valid duration.

formatDuration(0.9);
// expected output: '0.9 milliseconds' or '900 microseconds'
// actually output: ''