Code Monkey home page Code Monkey logo

go-littlefs's People

Contributors

bgould avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

go-littlefs's Issues

Potential undefined behavior on 64 bit system

Note: This is all done on a local machine and it works fine on the actual board, but would prefer to do local testing before uploading it to the board every time

Initial Error that caused the search. Tinyfs MemDevice (should be compatible with littlefs.New(device)

Tinyfs Device Values: {size: 16777216} {BlockSize: 256} {EraseSize: 4096}
2021/09/24 15:31:15 Panic: Offset: 0
Size: 760209211648
Block: 1
--- FAIL: Test_LFS (0.01s)
panic: runtime error: slice bounds out of range [::760209211648] with length 268435456 [recovered]
panic: runtime error: slice bounds out of range [::760209211648] with length 268435456

After alot of testing and discussion, I believe the issue to be related to some behavior of c int vs go int in the lfs callbacks
In go_lfs_callbacks.go
Changing this:
func go_lfs_block_device_read(ctx unsafe.Pointer, block uint32, offset uint32, buf unsafe.Pointer, size int) int {
To
func go_lfs_block_device_read(ctx unsafe.Pointer, block uint32, offset uint32, buf unsafe.Pointer, size uint32) uint32 {

Defining the expected behavior like this seems to fix the issue. The issue also exists with go_lfs_block_device_prog.

If all seems fine I can submit a PR or let you make the change. Any feedback welcome

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.