Code Monkey home page Code Monkey logo

Comments (9)

Liam-Newell avatar Liam-Newell commented on May 14, 2024

Hey! @bfirsh I'd love to work on this as my first bug. Do you mind if i try to make a pull request for this? and do you have an suggestions?

from jsnes-web.

Liam-Newell avatar Liam-Newell commented on May 14, 2024

I was thinking of adding an alternate button just next to the P2 control layout

from jsnes-web.

bfirsh avatar bfirsh commented on May 14, 2024

Yeah please!

I’m not sure what the best solution is to be honest. The downside of being right next to each other is that isn’t actually practical to play. (Imagine two people actually trying to do that.)

from jsnes-web.

Liam-Newell avatar Liam-Newell commented on May 14, 2024

from jsnes-web.

Liam-Newell avatar Liam-Newell commented on May 14, 2024

@bfirsh Oh, I didn't know if your comment was trying to on this, but after review of some other flash games it pretty popular to have p1 do wasd and p2 arrows keys(and so on)

from jsnes-web.

bfirsh avatar bfirsh commented on May 14, 2024

Yes, that seems reasonable, but it also needs to be done in a backwards compatible way.

Perhaps we could make P2 wasd, then add some P1 controls A/B/Start/Select controls near the arrow keys. Hmmmm. That seems overly complex.

from jsnes-web.

Liam-Newell avatar Liam-Newell commented on May 14, 2024

Personally I like the left to right idea for control but its your thing, currently its assigned to p1 wasd p2 arrow keys; with p1 having G & H for A & B and p2 having ; & ' for A & B

from jsnes-web.

Liam-Newell avatar Liam-Newell commented on May 14, 2024

I'm confused, are you referring to something else you're working on, or my work here? @studywithyou

from jsnes-web.

bfirsh avatar bfirsh commented on May 14, 2024

Fixed by #136.

from jsnes-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.